Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elements/leader.lua lua error with WoW5. #143

Closed
tukz opened this issue Jul 31, 2012 · 5 comments
Closed

elements/leader.lua lua error with WoW5. #143

tukz opened this issue Jul 31, 2012 · 5 comments

Comments

@tukz
Copy link

tukz commented Jul 31, 2012

Hey haste, you forgot to add a condition in the update function of leader.lua for isLeader. You need to add a "not WoW5" condition in front of UnitIsPartyLeader(unit) else, on MoP, if the unit is not the leader, it try to execute UnitIsPartyLeader() which doesnt exist anymore in 5.0.

@tukz
Copy link
Author

tukz commented Jul 31, 2012

Same issue with leader TAG in tag.lua

@tukz
Copy link
Author

tukz commented Jul 31, 2012

and leaderlong tag :P

@tukz
Copy link
Author

tukz commented Jul 31, 2012

There is an issue as well with eclipsebar.lua. If the druid doesnt have any spec at all, it try to execute GetPrimaryTalentTree() which doesnt exist on 5.0. So a "not WoW5" condition is required here as well.

I didnt want to create another issue just for this so I just updated this one.

@tukz
Copy link
Author

tukz commented Jul 31, 2012

Same issue with assistant, make sure you check for not WoW5 if you include UnitIsPartyLeader()

@haste
Copy link
Member

haste commented Aug 12, 2012

All should be fixed with:
be68b10
e0d45ae
b6e00c0
56a56ab

@haste haste closed this as completed Aug 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants