Legion runebar

[p3lim]

This PR contains changes to the runebar element for Legion.
It also eliminates the need for #112.

These commits are compatible with both live and beta clients.

[ls-]

Could you address the issue I described here?

[p3lim]

Sure, but it'll have to wait until tomorrow.

[ls-]

No problem there. I decided to remind about it, cuz I wasn't sure whether or not you saw that comment. As you said, that PR had become too big, so it's quite possible, that you missed it 😅

[Blazeflack]

I think you may have unintentionally made some find&replace errors in the "Add Override support and rename the PostUpdate hook" commit.

All references to the "UpdateRune" function was replaced with "Update", most likely during your replacement of "PostUpdateRune" with "PostUpdate".

[Blazeflack]

I forgot to mention that this probably breaks the element, as there is now two functions named "Update", so one replaces the other.

[p3lim]

@Blazeflack You're right, must have slipped past when I rebased the branch.

[Blazeflack]

How hard would it be to merge Runes into the ClassIcons element?

[p3lim]

Every single classicon is handled by a single texture/frame group that all use the same API/system for updates (sans vehicles because of buggy API).
Runes use their own API, and they also have statusbars that needs to be managed and can sometimes proc etc.

In theory it's not hard to merge, but in practicality it's best to leave them separate, same with totems.

[Blazeflack]

That makes sense.

[p3lim]

Removed the compatibility code since 7.0 is already out.

[ls-]

Hi!

There's a bug here. Please, replace r, g, b with colors[1], colors[2], colors[3].

rune.bg:SetVertexColor(colors[1] * mu, colors[2] * mu, colors[3] * mu)

[p3lim]

There's a bug here. Please, replace r, g, b with colors[1], colors[2], colors[3].

Fixed.