Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gzip compression #1253

Closed
jvice152 opened this issue Dec 20, 2018 · 4 comments
Closed

add gzip compression #1253

jvice152 opened this issue Dec 20, 2018 · 4 comments
Assignees
@0x777
Labels
c/server Related to server e/quickfix can be wrapped up in few hours k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints

Comments

@jvice152
Copy link

perhaps someone could point me in the right direction.... is there a way to enable gzip compression on queries?

https://blog.hasura.io/architecture-of-a-high-performance-graphql-to-sql-server-58d9944b8a87

I see it being referred to, but cant find any examples of it. When doing large requests, i see the accept-encoding header of gzip, deflate but not on the response at all (content-encoding). Am i looking at this correctly?

TIA
@0x777
Copy link
Member

0x777 commented Dec 21, 2018

Hi, graphql-engine doesn't do any sort gzip compression of the response. However you can add a reverse proxy like caddy or nginx to do this.

@0x777 0x777 added k/enhancement New feature or improve an existing feature e/quickfix can be wrapped up in few hours p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints c/server Related to server labels Dec 21, 2018
@marionschleifer
Copy link
Contributor

I'm closing this issue. @jvice152 if you have any further questions, please re-open it 🙂

@shahidhk shahidhk changed the title Gzip compression? add gzip compression Jul 10, 2019
This was referenced Aug 28, 2019
Closed
Open
@marionschleifer marionschleifer assigned 0x777 and unassigned dsandip Aug 29, 2019
@Toub
Copy link

Toub commented Oct 10, 2019

I guess this issue should be closed as it has been fixed by #2751 ?

@rikinsk
Copy link
Member

rikinsk commented Oct 10, 2019

Yes indeed.

@rikinsk rikinsk closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x777 0x777

Labels
c/server Related to server e/quickfix can be wrapped up in few hours k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Toub @marionschleifer @jvice152 @0x777 @dsandip @rikinsk