Migrations fail if SQL file exists that is commented out

[dvasdekis]

Hi folks,

I was able to create a failure on boot that blocked the server from starting by including the below in a SQL migrations file:

/* Below doesn't work!
DROP TRIGGER IF EXISTS trigger_tbl_stg_option_details_update_time_checked ON tbl_stg_option_details;
CREATE OR REPLACE FUNCTION fx_tbl_stg_option_details_update_time_checked()
RETURNS trigger AS 'BEGIN
UPDATE tbl_stg_option_details
    SET NEW.time_checked = now();
END' LANGUAGE 'plpgsql';

CREATE TRIGGER trigger_tbl_stg_option_details_update_time_checked
  AFTER UPDATE OF return_json
  ON tbl_stg_option_details
  FOR EACH ROW
  EXECUTE PROCEDURE fx_tbl_stg_option_details_update_time_checked();
*/

Irrespective if the trigger works or doesn't etc., the statement should be ignored as it is commented out.

Thanks again! Your product is wonderful and this problem was easy to pinpoint :)

Am using hasura/graphql-engine:latest.cli-migrations docker image (beta 6)

[dvasdekis]

Sorry was potentially unclear - stick the above code in a new .sql migrations file

[0x777]

I guess you see an error like this?

{
    "statement": "....",
    "prepared": false,
    "error": {
        "exec_status": "EmptyQuery",
        "hint": null,
        "message": null,
        "status_code": null,
        "description": null
    },
    "arguments": []
}

Looks like the server doesn't accept empty queries. I think we should catch this error and return an empty response. For now if your migration file is empty (post comments), stick something like select 1; in the end to work around this.

[jflambert]

This has affected me today. select 1; works. Hasura 2.0.5 with Postgres 13.3

Doesn't feel like it should be treated as an error though.