Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-router should be upgraded to v5 #42

Closed
wawhal opened this issue Jul 4, 2018 · 6 comments
Closed

react-router should be upgraded to v5 #42

wawhal opened this issue Jul 4, 2018 · 6 comments
Labels
c/console Related to console help wanted Good candidate for contribution. Community help wanted! k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints

Comments

@wawhal
Copy link
Contributor

wawhal commented Jul 4, 2018

No description provided.

@wawhal wawhal self-assigned this Jul 4, 2018
@praveenweb praveenweb added the c/console Related to console label Jul 5, 2018
@shahidhk shahidhk changed the title [console] react-router should be upgraded to react-router 4 react-router should be upgraded to react-router 4 Jul 6, 2018
@praveenweb praveenweb added the k/enhancement New feature or improve an existing feature label Jul 11, 2018
@praveenweb
Copy link
Member

  • Change <Link> imports
  • onEnter is not supported in v4. Move all onEnter to react's lifecycle methods.
  • Update HTML structure
  • Update dependencies like react-router-redux

@wawhal
Copy link
Contributor Author

wawhal commented Jul 18, 2018

@praveenweb this can’t be done. react-router-redux does not work with v4. However, keeping this issue open to see if anybody has alternatives.

@wawhal wawhal added the help wanted Good candidate for contribution. Community help wanted! label Jul 20, 2018
@abenhamdine
Copy link

https://github.com/supasate/connected-react-router works with react-router (and AFAIK is the only alternative since react-router-redux is deprecated).

It works with react-router v4 but you have to install from git for that : see supasate/connected-react-router#80

@abraha2d
Copy link

supasate has released a new version of connected-react-router on npm that works with react-router v4. No more need to install from git.

@abenhamdine
Copy link

supasate has released a new version of connected-react-router on npm that works with react-router v4. No more need to install from git.

Yes, good catch.

shahidhk pushed a commit to shahidhk/graphql-engine that referenced this issue Sep 11, 2018
@surendran82
Fixes hasura#42
15a9a20
shahidhk pushed a commit to shahidhk/graphql-engine that referenced this issue Sep 11, 2018
@rikinsk
Merge pull request hasura#42 from hasura/issue-27
073d5e1 
Issue 27 & 40
@dsandip dsandip assigned karthikvt26 and unassigned wawhal Sep 19, 2018
@dsandip
Copy link
Member

dsandip commented Jan 20, 2019

@shahidhk @karthikvt26 What's the status on this?

@dsandip dsandip added the p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints label May 21, 2019
jberryman pushed a commit to jberryman/graphql-engine that referenced this issue Aug 13, 2019
@tirumaraiselvan
Merge pull request hasura#42 from jberryman/remote-relationships-v2-m…
ed56696 
…erge-master

Merge master
@wawhal wawhal changed the title react-router should be upgraded to react-router 4 react-router should be upgraded to v5 Jan 6, 2020
hgiasac pushed a commit to hgiasac/graphql-engine that referenced this issue Dec 19, 2023
@ecthiender @hgiasac
[breaking] address review comments for permissions (hasura#42)
0eaee63 
* address review comments for output type permissions

* rename typeOutputPermissions -> outputTypePermissions

* revert rename of typeOutputPermissions

* rename `modelSelectPermissions.selectPermissions` -> `modelSelectPermissions.permissions`

* rename `modelSource.table` -> `modelSource.collection`
    also update codebase to rename all references to table to collection

GitOrigin-RevId: cfbff7892290dca3c5bf6d8faad9de6c1dc89ec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/console Related to console help wanted Good candidate for contribution. Community help wanted! k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@rikinsk-zz @abraha2d @abenhamdine @praveenweb @dsandip @karthikvt26 @wawhal