Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.3 tarball sha256 change? #6349

Open
carlocab opened this issue Dec 15, 2020 · 6 comments
Open

v1.3.3 tarball sha256 change? #6349

carlocab opened this issue Dec 15, 2020 · 6 comments
Labels
support/needs-action support ticket that requires action by team

Comments

@carlocab
Copy link

We're attempting to update Homebrew's version of Go (Homebrew/homebrew-core#66355).

While testing the new version, CI produced the following error:

==> brew install --build-from-source hasura-cli
==> FAILED
==> Downloading https://github.com/hasura/graphql-engine/archive/v1.3.3.tar.gz
==> Downloading from https://codeload.github.com/hasura/graphql-engine/tar.gz/v1.3.3
Error: SHA256 mismatch
Expected: 20d6e4d2da8e9ad4008683e3427e496ce9a96044b549385595bc681acbd8607a
  Actual: 2171bd0611719ed2340c783fdb2ac8f98cfafb608ec7898074627ece90f7ad5c

I can update the sha256 associated with the formula, but CI will come back to me with the following error:

hasura-cli:
  * stable sha256 changed without the url/version also changing; please create an issue upstream to rule out malicious circumstances and to find out why the file changed.

Can I confirm that nothing is amiss here?

@tirumaraiselvan
Copy link
Contributor

We had a release of v1.3.3 which was in draft initially, it was then removed and after few days a proper v1.3.3 release was made. Did the SHA get cached somewhere when it was a draft release? I am not really sure what is happening.

@carlocab
Copy link
Author

carlocab commented Dec 16, 2020

Homebrew hasura-cli was upgraded to v1.3.3 here: Homebrew/homebrew-core#64534

It seems you have this process automated somehow. I suspect that this was still a draft release when this happened.

@carlocab
Copy link
Author

@chenrui333 FYI, I think your bump action picked up a draft release.

@tirumaraiselvan tirumaraiselvan added the support/needs-action support ticket that requires action by team label Dec 16, 2020
@tirumaraiselvan
Copy link
Contributor

We didn't bump action as part of our release. The homebrew package is community maintained, so quite surprised somebody picked this up in draft stage.

@tirumaraiselvan
Copy link
Contributor

Is it possible to send a new patch to override this Homebrew/homebrew-core#64534?

@carlocab
Copy link
Author

Someone's already opened a PR to fix the recorded SHA256: Homebrew/homebrew-core#67065

As for the bump action, I'm not sure how that got set up, so I don't know how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support/needs-action support ticket that requires action by team
Projects
None yet
Development

No branches or pull requests

2 participants