Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix console tests #68

Closed
wawhal opened this issue Jul 10, 2018 · 1 comment
Closed

fix console tests #68

wawhal opened this issue Jul 10, 2018 · 1 comment
Assignees
@wawhal
Labels
c/console Related to console k/bug Something isn't working

Comments

@wawhal
Copy link
Contributor

wawhal commented Jul 10, 2018 •
edited by shahidhk

Tests are now failing for console, refer attachment.
console-tests.log
@wawhal wawhal self-assigned this Jul 10, 2018
wawhal added a commit that referenced this issue Jul 10, 2018
@wawhal
console: Fix #68
bbe61c6
@shahidhk shahidhk added the c/console Related to console label Jul 10, 2018
@shahidhk shahidhk changed the title console: update Makefile target "test" update Makefile target "test" Jul 10, 2018
@shahidhk shahidhk changed the title update Makefile target "test" fix console tests Jul 10, 2018
@shahidhk shahidhk added the k/bug Something isn't working label Jul 10, 2018
@shahidhk
Copy link
Member

Fixed in 3a085da

shahidhk pushed a commit to shahidhk/graphql-engine that referenced this issue Sep 11, 2018
@rikinsk
Merge pull request hasura#68 from hasura/docs-graphql-engine-error-ha…
e9d2a57 
…ndling

Docs graphql engine error handling
@codingkarthik codingkarthik mentioned this issue Dec 28, 2020
Closed
hgiasac pushed a commit to hgiasac/graphql-engine that referenced this issue Dec 19, 2023
@codingkarthik @hgiasac
Fix bug while querying id field in the node selection set (hasura#68)
82f893a 
* fix bug while querying `id` field in the node selection set

* remove the faulty implementation of relay id in `node` field

* Fix the global `id` being included in the selection set

* remove redundant `global_id_value` field

* Minor refactors

* add a comment

* just fix

* Include alias in global_id field prefix

* remove the global id fields from the row

* Address review comments

* just fix-ed

GitOrigin-RevId: 3e8eabcea6577c8f0181a12bfa13d82e27a950a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wawhal wawhal

Labels
c/console Related to console k/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shahidhk @wawhal