Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: escape data source name when used for routing #6994

Open
iykekings opened this issue May 28, 2021 · 1 comment
Open

console: escape data source name when used for routing #6994

iykekings opened this issue May 28, 2021 · 1 comment
Assignees
Labels
a/data c/console Related to console k/bug Something isn't working

Comments

@iykekings
Copy link
Contributor

iykekings commented May 28, 2021

To recreate: create a data source with name that contains % or any other accepted special characters, then on manage database, click view database

@beerose beerose added c/console Related to console k/bug Something isn't working labels May 28, 2021
@rikinsk
Copy link
Member

rikinsk commented Jun 9, 2021

We should extend this to all identfiers we set in any urls. i.e. data sources, tables, schemas, actions, remote schemas, triggers and so on.

e.g. I have a schema called boo/boo which causes a 404 when tried to be accessed

Screenshot from 2021-06-09 18-11-53

@vijayprasanna13 vijayprasanna13 self-assigned this Jun 24, 2021
@rikinsk rikinsk assigned rikinsk and unassigned 0x777 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/data c/console Related to console k/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants