Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support renaming tables, columns and relationships #79

Closed
rakeshkky opened this issue Jul 10, 2018 · 8 comments · Fixed by #1542
Closed

support renaming tables, columns and relationships #79

rakeshkky opened this issue Jul 10, 2018 · 8 comments · Fixed by #1542
Assignees
@rakeshkky
Labels
c/console Related to console c/server Related to server design-rfc Picked up by product design team for RFC e/hard Will take weeks of effort p/urgent Immediate action required s/wip Status: This issue is a work in progress
Milestone
v1.0.0-alpha39

Comments

@rakeshkky
Copy link
Member

No description provided.

@rakeshkky rakeshkky added the c/server Related to server label Jul 10, 2018
@rakeshkky rakeshkky self-assigned this Jul 10, 2018
@0x777 0x777 added the c/console Related to console label Jul 11, 2018
@rakeshkky rakeshkky added the s/wip Status: This issue is a work in progress label Jul 17, 2018
@rakeshkky rakeshkky mentioned this issue Aug 6, 2018
Closed
@praveenweb praveenweb added the design-rfc Picked up by product design team for RFC label Aug 27, 2018
shahidhk added a commit to shahidhk/graphql-engine that referenced this issue Sep 11, 2018
@shahidhk
Merge pull request hasura#79 from hasura/angularjs-quickstart
0dc1157 
add angularjs-hasura tutorials
@dsandip dsandip added the p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints label Sep 19, 2018
@dsandip dsandip added this to the v1.0.0-beta.01 milestone Sep 19, 2018
@0x777 0x777 changed the title support renaming tables and columns support renaming tables, columns and relationships Jan 7, 2019
@0x777 0x777 added p/high candidate for being included in the upcoming sprint e/hard Will take weeks of effort and removed p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints labels Jan 7, 2019
@0x777 0x777 mentioned this issue Jan 7, 2019
Closed
@0x777 0x777 mentioned this issue Jan 17, 2019
Closed
@dsandip
Copy link
Member

dsandip commented Jan 20, 2019

@nukinuki FYI

@0x777 0x777 added p/urgent Immediate action required and removed p/high candidate for being included in the upcoming sprint labels Jan 28, 2019
@0x777 0x777 modified the milestones: v1.0.0-beta.01, v1.0.0-alpha38 Jan 29, 2019
@dsandip
Copy link
Member

dsandip commented Jan 30, 2019

Console wireframes

  1. Option to rename table name and column name in the Modify tab of a table:

edit-table-column-name-1

  1. In-place edit for table name:

edit-table-column-name-2

  1. Option to edit relationship name:
    edit-relationship-name-1

  2. In-place edit for relationship name:

edit-relationship-name-2

@shahidhk @rikinsk please take a look at this. I am unsure about whether the option to edit the table name in 1 above is to be shown in the modify tab alone or in all tabs. I would prefer to limit it to the first option.

@dsandip
Copy link
Member

dsandip commented Jan 30, 2019

From @rikinsk (who has requested a chat with him before working on the frontend) - change the Remove button to the style used for columns i.e. call it Edit. Clicking on this button gives you 3 options: Save, Cancel and Remove.

@rakeshkky rakeshkky mentioned this issue Jan 31, 2019
Merged
21 tasks
@shahidhk
Copy link
Member

shahidhk commented Feb 4, 2019

Editing the table name can go inside the Modify tab.

@dsandip dsandip mentioned this issue Feb 4, 2019
Closed
@0x777 0x777 modified the milestones: v1.0.0-alpha38, v1.0.0-alpha39 Feb 8, 2019
@tirumaraiselvan
Copy link
Contributor

Also needs to update event trigger metadata. @rakeshkky

0x777 pushed a commit that referenced this issue Mar 1, 2019
@rakeshkky @0x777
allow renaming tables, columns and relationships (close #79) (#1542)
6c20ca8
codingkarthik added a commit to codingkarthik/graphql-engine that referenced this issue Feb 25, 2020
@codingkarthik
add tests for scheduled triggers (hasura#79)
0ca80a7 
  - Make a new scheduled events webhook server on port 5594
  - Setting the session timezone of the db to UTC so that
    "SELECT NOW()" returns UTC time.
  - Cron's schedule is set from 30 mins from the time the tests run, so it
    will not be run(to avoid race condition between the cron ST and the adhoc
    ST)
  - The tests will run for a maximum of a minute(until the event is fired)
@nolandg
Copy link

nolandg commented May 21, 2020

Can anyone explain how this helps in deleting columns? The "can't delete column because of permissions" links here but...? Is the only way to delete a column to through all the permissions for all rows removing that column first? I have 32 boxes to click then... :-(

@rikinsk
Copy link
Member

rikinsk commented May 21, 2020 •
edited

@nolandg We are working on improving the console experience for this. It being tracked in #1593. As a workaround till then you can drop the column via SQL in the RawSQL tab using ALTER TABLE <table> DROP <column> statement and checking the Cascade metadata checkbox. This will drop all permissions depending on the given column. Note that for row level permissions the entire permission will be dropped and not just clause containing the column

@Rigel772
Copy link

Rigel772 commented Jul 14, 2022 •
edited

After I use : ALTER TABLE <table> DROP <column> statement and checking the Cascade metadata checkbox.'
I got error:

SQL Execution Failed
source with name "default" does not exist

(in hasura console 2.8.3 running from CLI 2.8.3)

hgiasac pushed a commit to hgiasac/graphql-engine that referenced this issue Dec 19, 2023
@purugupta99 @hgiasac
add basic role based permissions for commands (hasura#79)
4ebd702 
* initial commit

* lint

* review comments

* update tests

* lint

GitOrigin-RevId: 82211ef7913a1aedd10ffd72b3a813d2101c39d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakeshkky rakeshkky

Labels
c/console Related to console c/server Related to server design-rfc Picked up by product design team for RFC e/hard Will take weeks of effort p/urgent Immediate action required s/wip Status: This issue is a work in progress
Projects
None yet
Milestone
v1.0.0-alpha39
9 participants
@Rigel772 @shahidhk @nolandg @0x777 @tirumaraiselvan @rakeshkky @praveenweb @dsandip @rikinsk