Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field arguments in query_collection are not validated correctly #8641

Open
lorenzo opened this issue Jun 28, 2022 · 1 comment
Open

field arguments in query_collection are not validated correctly #8641

lorenzo opened this issue Jun 28, 2022 · 1 comment
Assignees
Labels
k/bug Something isn't working

Comments

@lorenzo
Copy link
Contributor

lorenzo commented Jun 28, 2022

Version Information

Server Version: 2.8.1

Environment

OSS

What is the expected behaviour?

Queries in query_collection should be validated against the schema and be marked as inconsistent. This is not the case when using the new naming convention.

Keywords

naming convention, graphql-default

What is the current behaviour?

While testing the new naming convention with an existing setup, I had an error with a REST endpoint. The query look something like this:

query {
   myFunction(args: {foo_bar: "baz"}) {
      id
   }
}

The query is incorrect, as with the new query convention, the arguments are now camelCased. The correct query should have been:

query {
   myFunction(args: {fooBar: "baz"}) {
      id
   }
}

Storing the former query in the metadata was possible, but resulted in a runtime error when running it.

If the bug is confirmed, would you be willing to submit a PR?

No

@lorenzo lorenzo added the k/bug Something isn't working label Jun 28, 2022
@lorenzo
Copy link
Contributor Author

lorenzo commented Jun 28, 2022

related to #8640

@paritosh-08 paritosh-08 self-assigned this Jun 29, 2022
@paritosh-08 paritosh-08 changed the title Queries in query_collection are not validated correctly when using the graphql-default naming convention field arguments in query_collection are not validated correctly Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants