Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for /api/1/table endpoint #86

Closed
ecthiender opened this issue Jul 10, 2018 · 5 comments
Closed

add tests for /api/1/table endpoint #86

ecthiender opened this issue Jul 10, 2018 · 5 comments
Labels
c/server Related to server e/quickfix can be wrapped up in few hours p/longterm Low priority issues that will be picked up based on user feedback or bandwidth

Comments

@ecthiender
Copy link
Member

ecthiender commented Jul 10, 2018 •
edited

This endpoint is no longer required.

https://github.com/ecthiender/graphql-engine/blob/issue-13-server-tests/server/src-lib/Hasura/Server/App.hs#L440
@ecthiender ecthiender added the c/server Related to server label Jul 10, 2018
@shahidhk shahidhk added the e/quickfix can be wrapped up in few hours label Sep 7, 2018
@shahidhk
Copy link
Member

shahidhk commented Sep 7, 2018

@0x777 @ecthiender @coco98 I suggest we do not remove this as HGE is used in platform too.

Let's take a call and close this issue off?

@coco98
Copy link
Contributor

coco98 commented Sep 7, 2018 •
edited

Let's just add tests for it, let it be and close this issue? Is it a pain to have running? @ecthiender?

shahidhk pushed a commit to shahidhk/graphql-engine that referenced this issue Sep 11, 2018
@karthikvt26
Merge pull request hasura#86 from hasura/release-0.14
de05f61 
Release 0.14
@dsandip
Copy link
Member

dsandip commented Sep 19, 2018

@coco98 @nizar-m is this part of the tests coverage plan?

@dsandip dsandip added the p/longterm Low priority issues that will be picked up based on user feedback or bandwidth label Sep 19, 2018
@shahidhk shahidhk changed the title remove /api/1/table endpoint add tests for /api/1/table endpoint Oct 3, 2018
@ecthiender
Copy link
Member Author

I think we can close this issue, if we want to continue running /api/1/table.

@shahidhk
Copy link
Member

@nizar-m Since this query is translated to whatever v1/query does, let's just add one test to ensure that it's working and close this issue.

@0x777 0x777 closed this as completed Apr 30, 2019
hgiasac pushed a commit to hgiasac/graphql-engine that referenced this issue Dec 19, 2023
@sordina @hgiasac
Merge pull request hasura#86 from hasura/lyndon/adding-error-details-…
0e9e744 
…to-commands

Adding error details to console on command errors

GitOrigin-RevId: 41258394457ebfbc2722d0e806c53935e6472ddb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/server Related to server e/quickfix can be wrapped up in few hours p/longterm Low priority issues that will be picked up based on user feedback or bandwidth
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@coco98 @ecthiender @shahidhk @0x777 @dsandip