Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a configuration to configure total max event poolsize (cumulative count over horizontal scaling) #9236

Open
soorajshankar opened this issue Nov 21, 2022 · 0 comments
Labels
a/eventing/data-triggers k/enhancement New feature or improve an existing feature t/gql-services

Comments

@soorajshankar
Copy link
Member

soorajshankar commented Nov 21, 2022

Is your proposal related to a problem?

image

AFAIK the current the pool size configuration means `Max event processing threads` and this is per instance, and when Hasura runs horizontally this value could get multiplied.

What can go wrong?

image

  • Suppose If I have a event stream that goes down for some time
  • and when it comes back It could have significant load on the Hasura event queue
  • I would expect Hasura to unload that without having more than 100 (or whatever the poolsize) request at the same time.
  • Now if I have Hasura running horizontally (may be even with an auto scale setup) this could load my event handler in unexpectedly high rate.
  • (If I have 3 hasura instances up, Hasura would have 300 simultaneous requests, which I may not expect my RHS system to handle)
  • The event handler that I have in the RHS may not be designed to handle that much load, this could cause errors

Describe the solution you'd like

There should be a way to configure cumulative total max http poolsize instead of the event pool size. (just like total_max_connections)

Describe alternatives you've considered

If I have control over RHS, probably I can load balance RHS system or event increase the resources, but considering the expectation is to have Hasura manage the queue, this may not be a good solution.

@soorajshankar soorajshankar added k/enhancement New feature or improve an existing feature a/eventing/data-triggers t/gql-services labels Nov 21, 2022
@rahulagarwal13 rahulagarwal13 changed the title Provide a configuration to configure tatal max event poolsize (cumulative count over horizontal scaling) Provide a configuration to configure total max event poolsize (cumulative count over horizontal scaling) Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/eventing/data-triggers k/enhancement New feature or improve an existing feature t/gql-services
Projects
None yet
Development

No branches or pull requests

1 participant