Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented Breaking Change: previously added null fields are gone #9321

Open
IsaacLeeWebDev opened this issue Dec 20, 2022 · 2 comments
Open
Labels
k/enhancement New feature or improve an existing feature t/gql-services

Comments

@IsaacLeeWebDev
Copy link

Is your proposal related to a problem?

There's an undocumented breaking change between Hasura v1.3.4 and v2.12.1 (I don't have the time to isolate it to a smaller range right now, but I may come back and update it if I can!)

Here's the v1.3.4 behavior when you send a GraphQL request containing an operation document selecting fields from a Hasura Action whose backing REST API omits one or more of those fields in the response:

image

Here's the v2.12.1 behavior:

image

As you can see, the "message": null field in the v1.3.4 response was removed after the upgrade.

While there's not a huge difference between "something": null and nothing at all, some folks may– for some wild reason I can't think of– depend on that old behavior.

Describe the solution you'd like

Document this breaking change in the change log, or v2 migration guide.

Describe alternatives you've considered

I guess patching the behavior is possible, but that would be another breaking change to different versions, so 🤷

@IsaacLeeWebDev IsaacLeeWebDev added the k/enhancement New feature or improve an existing feature label Dec 20, 2022
@adas98012
Copy link
Contributor

adas98012 commented Dec 20, 2022

@rahulagarwal13

Related issue #9191 #8473

@rahulagarwal13
Copy link
Contributor

@IsaacLeeWebDev - got it, thanks for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/enhancement New feature or improve an existing feature t/gql-services
Projects
None yet
Development

No branches or pull requests

3 participants