Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate class components to functional components #68

Closed
itaditya opened this issue Oct 9, 2019 · 4 comments · Fixed by #70
Closed

Migrate class components to functional components #68

itaditya opened this issue Oct 9, 2019 · 4 comments · Fixed by #70

Comments

@itaditya
Copy link
Contributor

itaditya commented Oct 9, 2019

All components except Testimonials.js just have a render method. They don't use any special stuff which class components provide. Since there is a transpilation cost associated with class components, we should use function components instead.

Note- I'm not talking about adding hooks in the project. The only place where a hook would be useful is Testimonials.js but it is fine its current state. I'm just talking about other components which don't need hooks

@praveenweb
Copy link
Member

@itaditya - Makes sense. Would you like to work on this?

@itaditya
Copy link
Contributor Author

itaditya commented Oct 10, 2019

@praveenweb since I have already got three PRs merged, I'm eligible for Hasura Hacktoberfest t-shirt. So let's give this opportunity to someone else. If no one picks it up in the next two days, I'll work on it.

Also do I need to do anything else regarding the Hasura Hacktoberfest?

@deadcoder0904
Copy link
Contributor

I'll tackle this one :)

@deadcoder0904
Copy link
Contributor

Sent a PR #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants