New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook worker cancellation behavior #584

Open

steebchen opened this issue Jun 12, 2024 · 0 comments

Member

steebchen commented Jun 12, 2024 •

edited

Loading

see hatchet-dev/hatchet-typescript#106 (review) for details

with the current implementation, we'll make a new request to the worker to cancel the running step. with our grpc model, we send that request to the correct worker which has a ref to the running step run to cancel.
with the webhook worker, the request might get pickedup by a different lambda which will have no reference to the run...

Also, once the behavior is decided, this needs to be adapted in all SDKs individually

steebchen changed the title ~~Webhook worker cancellation~~ Webhook worker cancellation behavior

steebchen mentioned this issue

feat(webhooks): add webhook workflows hatchet-dev/hatchet-typescript#106

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment