Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "," in setup.py that causes wheel not to be built #214

Open
Magerly666 opened this issue Oct 5, 2023 · 1 comment
Open

Missing "," in setup.py that causes wheel not to be built #214

Magerly666 opened this issue Oct 5, 2023 · 1 comment

Comments

@Magerly666
Copy link

Magerly666 commented Oct 5, 2023

setup.py: Line 47

install_requires=[
    "click",
    "jinja2",
    "pefile>=2019.4.18, <2019.5.0"
    "pyyaml>=5.1",
@geeksailor
Copy link

geeksailor commented Nov 9, 2023

Devs,
My update to this, my requires.txt in ~/venv/vmcloak/VMCloak.egg-info/requires.txt now shows:

pefile<2019.5.0pyyaml>=5.1,>=2019.4.18

I think someone accidentally cut and pasted the pyyaml in the middle of the pefile requirements. This seems to screwing it up worse and is confusing vmcloak that it needs a pip package with that name when I run the command. See error output below:

pkg_resources.DistributionNotFound: The 'pefile<2019.5.0pyyaml>=5.1,>=2019.4.18' distribution was not found and is required by VMCloak

Also I know this is built to work with Cuckoo3 among other programs, but Cuckoo3 now requires pefile>=2022.5.30, <2024.0.0. This causes a dependency conflict between VMCloak and Cuckoo3 preventing one or the other from working. At least inside a virtualenv. I haven't found a possible solution yet, but I figured if someone finds one that allows having both programs working could be useful for creating and editing images and snapshots and doing analysis.

EDIT: Possible solution: rather than running both in the same virtualenv, I'm running both doing an install using pipx to separate their dependencies. VMCloak appears to runs with no issues now so far. It makes them available globally rather than having to target that directory to get to vmcloak-qemubridge to start a bridge interface.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants