Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vrde/vrdp capabilities to "vmcloak modify" #94

Open
MarkusTeufelberger opened this issue Jan 18, 2017 · 4 comments
Open

Add vrde/vrdp capabilities to "vmcloak modify" #94

MarkusTeufelberger opened this issue Jan 18, 2017 · 4 comments

Comments

@MarkusTeufelberger
Copy link
Contributor

I patched in a m.vrde(3389, "") into https://github.com/jbremer/vmcloak/blob/master/vmcloak/main.py#L385 to be able to modify VMs remotely. It might be useful to others too or a nice feature to have in general, since headless mode is probably a relatively common use case.

If this functionality is popular, I would just add it with 2 more options to the modify command and submit a pull request.

@jbremer
Copy link
Member

jbremer commented Jan 26, 2017

Hi. Yes, if you add an option to the command for specifying a VRDE port, that'd be great, and I'll merge it!
Thanks :-)

@razuz
Copy link
Contributor

razuz commented Jan 30, 2017

👍
however what do you modify there ? maybe it makes more sense to automate that ? :)
cause for cuckoo I'm not booting them up any more but possibly I've missed something that needs a restart after registry changes.

@MarkusTeufelberger
Copy link
Contributor Author

Some setup routines/installers are easier if you do them manually and writing packages in yet another format (called "dependencies" here) might be overkill for some users. Also it would be just analogous to the "gui" mode, that is also available in vmcloak.

Last but not least, modifying via a GUI or remotely instead of writing a dependency means that you don't have to share your modification scripts according to GPL, which might be motivation for some?

@razuz
Copy link
Contributor

razuz commented Jan 30, 2017

absolutely :) some installers are also quite picky and might become even impossible to implement.
Still - if there's some useful dependencies (complicated or not) you can always drop here :) Probably I can find some time to implement them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants