Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat calendar #85

Closed
wants to merge 10 commits into from
Closed

Feat calendar #85

wants to merge 10 commits into from

Conversation

amahalwy
Copy link
Contributor

@amahalwy amahalwy commented Jun 4, 2021

What this PR does (required):

  • Adding in a new calendar component to display different views for users.
  • Adding a new menu to change the display between board and calendar.

Screenshots / Videos (required):

  • Functionality available here.

Any information needed to test this feature (required):

  • Pull PR and simply run it! Nothing special needed

Any issues with the current functionality (optional):

  • This is only preliminary; dependencies exist on the backend refactoring of the cards model to allow updating of card dates through the calendar.
  • Some functionality will be integrated/adapted as backend card model is completed.

@amahalwy amahalwy linked an issue Jun 4, 2021 that may be closed by this pull request
@amahalwy
Copy link
Contributor Author

amahalwy commented Jun 4, 2021

@street-jackal Assigning you here to keep in the loop with how the calendar expects the card model and its properties (see initCalendarCards function to see what's going on there; the calendar wants title and date instead of name, which is what we have).

You'll also need to adapt the way Dates are created to work alongside the calendar component instead of using a function to manipulate the dates; this function will still run likely because each card should be able to have different tag colours.

Let me know what you think!

@amahalwy amahalwy marked this pull request as draft June 4, 2021 00:41
@jonmmyers
Copy link
Collaborator

@street-jackal Assigning you here to keep in the loop with how the calendar expects the card model and its properties (see initCalendarCards function to see what's going on there; the calendar wants title and date instead of name, which is what we have).

You'll also need to adapt the way Dates are created to work alongside the calendar component instead of using a function to manipulate the dates; this function will still run likely because each card should be able to have different tag colours.

Let me know what you think!

Ok so just to confirm, we need to change the variable name to title for cards throughout the app? I will incorporate that in the PR I'm working on if so.

@amahalwy amahalwy marked this pull request as ready for review June 14, 2021 01:16
Copy link
Collaborator

@jonmmyers jonmmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good and calendar feature seems to be working well!

The issue where a card's columnId isn't getting updated when it's moved via drag and drop is back when I checkout this branch, any chance that fix wasn't pulled into your code?

@amahalwy amahalwy closed this Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Calendar
2 participants