Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for式のfilterに関する記述 #16

Closed
xuwei-k opened this issue Oct 29, 2015 · 2 comments
Closed

for式のfilterに関する記述 #16

xuwei-k opened this issue Oct 29, 2015 · 2 comments

Comments

@xuwei-k
Copy link
Contributor

xuwei-k commented Oct 29, 2015

https://github.com/hatena/Hatena-Textbook/blob/71680f6d034f8a904e075adecf16faff79ffc653/foundation-of-programming-scala.md#ガードつきのfor

filter メソッドが実装されてるとifでfilterできる

という箇所、withFilterについて書いてない。そもそもテキストのScalaのversionの指定がない(?)ので、どう修正すべきかは、どのScalaのversionをサポートするのか?によるが

  • 古いversionもケアするなら、filterとwithFilter両方に関して(歴史的なこと含め)説明をかく
  • 最新versionのScalaだけでいいなら、上記のfilterの記述をwithFilterに単に置き換えるべき
@xuwei-k
Copy link
Contributor Author

xuwei-k commented Oct 29, 2015

そもそもテキストのScalaのversionの指定がない

scalaVersion := "2.11.7"

という記述はあるか

@hakobe
Copy link
Contributor

hakobe commented Dec 9, 2015

#18 こちらで記載を追加するなどしました。ご指摘ありがとうございました!!

@hakobe hakobe closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants