Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TUD_HID_REPORT_DESC_GAMEPAD comment outdated #1199

Closed
chegewara opened this issue Nov 17, 2021 · 1 comment · Fixed by #1214
Closed

TUD_HID_REPORT_DESC_GAMEPAD comment outdated #1199

chegewara opened this issue Nov 17, 2021 · 1 comment · Fixed by #1214
Labels
Bug 🐞

Comments

@chegewara
Copy link

Operating System

Others

Board

all

Firmware

hid gamepad

What happened ?

Sorry for complaining, but this comment is a bit old and misleading and HID gamepad descriptor does not match it.
Currently descriptor is built for 32 buttons.

How to reproduce ?

https://github.com/hathach/tinyusb/blob/master/src/class/hid/hid_device.h#L313-L314

Debug Log

No response

Screenshots

No response
@hathach
Copy link
Owner

hathach commented Nov 17, 2021

right, it is out dated, would you mind making an PR to correct it ?

@hathach hathach mentioned this issue Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correct 32 button in gamepad hid descriptor template hathach/tinyusb
2 participants
@hathach @chegewara