-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator for StyledProperty does not work anymore on Avalonia 11.0.0 preview6 #11
Comments
While this fix is fairly trivial and is already in the process of being shipped to NuGet, I see that they have also added other changes that break the tests. Please try and let me know if this applies to you. |
I'm not entirely sure if the other changes will apply to older versions as well. There are two ways here - to introduce the MSBuild property DependencyPropertyGenerator_UseAvaloniaPreview, which the generator will read and generate the correct code, or wait until these versions come out of preview. I will implement the first option if there are messages from you or other users that this is necessary. |
The 1.2.5 nuget version works thanks but now I get the message "error TRF001: Framework is not recognized" Yet I have the constant defined in my csproj: |
Message from Intellisence or message when compiling? |
When compiling |
Is it something related to https://github.com/HavenDV/H.Generators.Extensions/blob/108ce2b09a42ddfd1573c78c82617419fa58df47/src/libs/H.Generators.Extensions/AnalyzerConfigOptionsProviderExtensions.cs#L141 Do I need to set particular settings in my csproj (RecognizeFramework_DefinedConstants...)? |
Yes, try setting |
Did version 1.2.4 work for you? What version did you update from? |
Perhaps your build fails for another reason, but you see not the build log, but Intellisence errors that may not be correct? |
I've found the problem. I didn't add a reference to the DependencyPropertyGenerator package (+ DefineConstants) in the project. I thought it would consume the package as transient from a referenced project. It was working until now, so I didn't what changed since. BTW, it works, I'm happy ! Thank you very much for the time you've spent to help me, very appreciated :) |
Describe the bug
In the latest pre-release of Avalonia 11 (preview 6), the prototype of the Register method with the parameter
notifying
is now internal.Here a discussion on the Avalonia repo explaining the change: AvaloniaUI/Avalonia#10766
So your library cannot be used with this version and the later ones.
Steps to reproduce the bug
11.0.0-preview6
The project no longer builds.
Expected behavior
No response
Screenshots
No response
NuGet package version
No response
IDE
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: