Add API functions to get wallet transfers and withdraw funds [$400]

[woodser]

This issue requests adding new API functions to get transfers and withdraw funds.

These API calls will feed the UI wallet functionality:

The following functions are requested as additions to HavenoDaemon.ts. Feedback is welcome.

API Function	Return	Description
havenod.getXmrTxs()	XmrTx[]	Get all transactions with transfers from or to Haveno's Monero wallet.
havenod.createXmrTx(destinations: XmrDestination)	XmrTx	Create but do not relay a transaction to send funds from Haveno's Monero wallet.
havenod.relayXmrTx(txMetadata: string)	string	Relay a previously created transaction.

XmrTx
hash: string
timestamp: timestamp
transfers: XmrTransfer[]
metadata: string // used to later relay the transaction

XmrTransfer
address: string
amount: BigInt // as string in gRPC
isIncoming: boolean
destinations: XmrDestination[] // only present on outgoing transfers from local wallet data

XmrDestination
address: string
amount: BigInt // as string in gRPC

Note these wallet functions are already implemented:

API Function	Return	Description
havenod.getNewDepositSubaddress()	string	Get a new subaddress in the Haveno wallet to receive deposits.
havenod.getBalances()	XmrBalanceInfo	Get the user's Monero balances.

How to implement

A test should be added to HavenoDaemon.test.ts to test all Haveno wallet functions including sending and receiving funds and testing wallet balances and transactions.

Follow these instructions to add and test new API functions end-to-end.

[github-actions]

There is a bounty on this issue, the amount is in the title. The bounty will be awarded to the first person(s) who resolves this issue. Read the full conditions in the 'bounties.md' file. If you are starting to work on this issue, please write a comment here, so that we can assign the issue to you and avoid duplicated work.

[l0nelyc0w]

I can begin working on this issue.

[woodser]

@l0nelyc0w Checking in. How's it going?

[l0nelyc0w]

@woodser I managed to get getXmrTxs working with the tests after the problem I had with null values, I followed ProcessModel.java and it helped to get the reply back. I have a question regarding createXmrTx(destinations) though, destinations isn't the only parameter for createXmrTx() right? It should also have the desired amount and the rest of fields that are mandatory to create a tx (as transfer in Monero RPC doc). And relayXmrTx() should take as it's only parameter the tx_metadata created by createXmrTx() (as relayTx in Monero RPC doc).

I think I will have a PR ready within the next 7 days.

[woodser]

@l0nelyc0w The amounts are part of the destinations. The only other required field is the account index which is always 0 for Haveno's wallet, so it doesn't need to be provided.

Yes, relayTxXmr() should take the tx metadata as an argument (I fixed the documentation).

[l0nelyc0w]

@woodser

The only other required field is the account index which is always 0 for Haveno's wallet, so it doesn't need to be provided.

OK account index was the actual field of interest thank you for clarifying.

[erciccione]

PR: #199

[erciccione]

Reward sent. @l0nelyc0w please confirm you received it :)

[erciccione]

Closing this as resolved.

[l0nelyc0w]

I confirm I got the reward @erciccione thank you :)