Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API function to receive notifications [$300] #147

Closed
woodser opened this issue Oct 29, 2021 · 11 comments · Fixed by #209
Closed

Add API function to receive notifications [$300] #147

woodser opened this issue Oct 29, 2021 · 11 comments · Fixed by #209
Assignees
Labels
a:api Related to the gRPC API 💰bounty There is a bounty on this issue is:feature Request for a new feature P2 high priority

Comments

@woodser
Copy link
Contributor

woodser commented Oct 29, 2021

This issue requests adding a new API function to receive notifications.

This API call will feed the UI notifications:

image

The following function is requested as an addition to HavenoDaemon.ts (feedback welcome).

API Function Return Description
havenod.onNotification(listener: function) void Invokes the given function on each new notification. Usage: await havenod.onNotification(function(notification: Notification) { ... });

How to implement

We want the client to receive a push notification from the gRPC backend for each notification.

We intend to use gRPC streaming and/or websockets to achieve push notifications. Here is some documentation to get started:

Follow these instructions to add and test new API functions end-to-end.

@woodser woodser added a:api Related to the gRPC API P2 high priority P3 normal priority is:feature Request for a new feature and removed P2 high priority labels Oct 29, 2021
@erciccione erciccione added this to To do in Build Haveno's API via automation Oct 29, 2021
@erciccione erciccione changed the title Add API function to receive notifications Add API function to receive notifications [$300] Oct 29, 2021
@erciccione erciccione added the 💰bounty There is a bounty on this issue label Oct 29, 2021
@erciccione erciccione added this to Open in Bounty program via automation Oct 29, 2021
@github-actions
Copy link

There is a bounty on this issue, the amount is in the title. The bounty will be awarded to the first person(s) who resolves this issue. Read the full conditions in the 'bounties.md' file. If you are starting to work on this issue, please write a comment here, so that we can assign the issue to you and avoid duplicated work.

@KritR
Copy link

KritR commented Nov 5, 2021

I’d be interested in working on this.

@erciccione
Copy link
Contributor

Thanks @KritR. I'm assigning the issue to you. Please keep us updated :)

@woodser woodser added P2 high priority and removed P3 normal priority labels Nov 21, 2021
@erciccione
Copy link
Contributor

Hey @KritR. Could you share an update on how things are going? :)

@LumnitzF
Copy link
Contributor

LumnitzF commented Jan 8, 2022

I would like to work on this feature.
Open questions:

  1. What fields should the Notification provide?
  2. Should multiple listeners be supported, or only one per daemon?
  3. Should there also exist the possibility to remove a message listener again?

@erciccione
Copy link
Contributor

Of course, assigning it to you. Thanks @LumnitzF! :)

@erciccione
Copy link
Contributor

@erciccione erciccione moved this from Open to Patch proposed in Bounty program Jan 9, 2022
@erciccione erciccione moved this from To do to In progress in Build Haveno's API Jan 9, 2022
Build Haveno's API automation moved this from In progress to Done Jan 13, 2022
@LumnitzF
Copy link
Contributor

@erciccione / @woodser Could you please send the bounty to:

85TXCCFva9ULot4D3bvBpeJ6aMHyUeKJCNeeLAXhobL2C6dvZAFKpjwHKfeeQmbrRoYcf4DddkAWzRRTGqwAS5vu4efa1nV

Thanks in advance :)

@erciccione erciccione moved this from Patch proposed to Patch accepted in Bounty program Jan 13, 2022
@erciccione
Copy link
Contributor

Reward sent! @LumnitzF please comment here when you receive it :)

@erciccione erciccione moved this from Patch accepted to Reward sent (resolved) in Bounty program Jan 14, 2022
@LumnitzF
Copy link
Contributor

@erciccione Received the bounty. Thank you!

@woodser
Copy link
Contributor Author

woodser commented Jan 14, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api Related to the gRPC API 💰bounty There is a bounty on this issue is:feature Request for a new feature P2 high priority
Projects
Bounty program
Reward sent (resolved)
Development

Successfully merging a pull request may close this issue.

4 participants