Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bisq-* cli tools to haveno-* #24

Closed
woodser opened this issue Apr 17, 2021 · 4 comments · Fixed by #63
Closed

Rename bisq-* cli tools to haveno-* #24

woodser opened this issue Apr 17, 2021 · 4 comments · Fixed by #63
Assignees
Labels
a:repo Changes about the repository good first issue Good for newcomers

Comments

@woodser
Copy link
Contributor

woodser commented Apr 17, 2021

This issue requests the ./bisq-* cli tools be renamed to ./haveno-*..

@erciccione erciccione added a:repo Changes about the repository good first issue Good for newcomers labels Apr 17, 2021
@erciccione erciccione added this to To do in Clean repo from Bisq-specific content via automation Apr 17, 2021
@newsyp
Copy link

newsyp commented Apr 17, 2021

Yup this one looks like the job for me!

If no one got this one I got this one.

@newsyp
Copy link

newsyp commented May 3, 2021

I've switched the package name of the java files within the cli folder from bisq.cli to haveno.cli and the same for the import statements pertaining java files within the cli folder.

I was unable to access the bisq.proto.grpc files to change bisq to haveno at the root so I left those imports alone. I had done some research into what grpc is and downloaded a few tools to help me work with them but its still unclear to me how these type of files work.

@newsyp
Copy link

newsyp commented May 3, 2021

I downloaded the haveno files to my computer and made the changes there, how do I bring them over for everyone else to access here on github?

@woodser
Copy link
Contributor Author

woodser commented May 3, 2021

newsyp

I downloaded the haveno files to my computer and made the changes there, how do I bring them over for everyone else to access here on github?

It's recommended to fork the Haveno repository, check out your fork locally, make the changes, push the changes to your forked repository, then open a pull request from your repository to the main Haveno repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:repo Changes about the repository good first issue Good for newcomers
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants