Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It has the potential to lock up the entire plasma workspace session #9

Closed
xiangzhai opened this issue Jul 29, 2015 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@xiangzhai
Copy link
Contributor

I'm a bit concerned by the blocking calls in AccountsService here:
https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107

That has the potential to lock up the entire plasma workspace session; which obviously isn't ideal.
Blocking calls are a problem if we can't rely on the remote service /always/ behaving.

@plfiorini plfiorini added the bug label Jul 29, 2015
@plfiorini plfiorini added this to the Version 0.7.0 milestone Jul 29, 2015
@plfiorini
Copy link
Member

Yep the API needs to be completely async

@plfiorini plfiorini mentioned this issue Jul 29, 2015
3 tasks
@xiangzhai
Copy link
Contributor Author

let`s fix it ;P

@plfiorini
Copy link
Member

Yes, added to the API review task list.

The plan:

0.7.0 is a release which should be as much reliable as we can.
This way issues that can lead to API changes are still allowed until 1.0 the most important concerns are already addressed with 0.7.0. With 0.7.0 we can add QtAccountsService as a (still optional) dep on sddm.

This means that 0.7.0 needs unit tests (already started doing that).

@plfiorini plfiorini self-assigned this Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants