Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] Text files should end with a newline character - in src/…/MiddlewarePipeAdapter.php, line 74 #5

Closed
mbunge opened this issue Mar 14, 2016 · 0 comments

Comments

@mbunge
Copy link
Contributor

mbunge commented Mar 14, 2016

in src/Stratigility/MiddlewarePipeAdapter.php, line 74

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

            $application->handle($request, $response);
        });
        return parent::__invoke($request, $response, $finalHandler);
    }

}

Posted from SensioLabsInsight

mbunge pushed a commit that referenced this issue Oct 1, 2016
mbunge added a commit that referenced this issue Oct 1, 2016
## 1.1.6

### Added

 - Add vagrant development environment
 - Add shutdown event
 - Add logic to force response emitting if headers already send

### Altered

 - Delegate request content type to response
 - Rename `Application::cleanUp` to `Application::collectGarbage`
 - Rename `Application::finishRequest` to `Application::shutdown`
 - Rename `Application::subscribe` to `Application::addListener`
 - Enhance error handling for different content types
 - Log application errors correctly, logging is silenced by default.

### Commitdetails

* Add vagrant development environment

* Fix typo

* Fix #14 Delegate request content type to response

* Update changelog

* Fix #16 fix output buffer termination

add shutdown event
rename `Application::cleanUp` to `Application::collectGarbage`
rename `Application::finishRequest` to `Application::shutdown`

* Fix code style. Fluent setter update

* Fix #17 Add logic for forcing response emitting

* Fix #15 Enhance error handling logic

* update content delegation

* update loggers

* log errors on runtime errors

* fix typo

* fix typo

* Fix #3, #4, #5
@mbunge mbunge closed this as completed Oct 1, 2016
mbunge added a commit that referenced this issue Oct 4, 2016
* Add vagrant development environment

* Fix typo

* Fix #14 Delegate request content type to response

* Update changelog

* Fix #16 fix output buffer termination

add shutdown event
rename `Application::cleanUp` to `Application::collectGarbage`
rename `Application::finishRequest` to `Application::shutdown`

* Fix code style. Fluent setter update

* Fix #17 Add logic for forcing response emitting

* Fix #15 Enhance error handling logic

* update content delegation

* update loggers

* log errors on runtime errors

* fix typo

* fix typo

* Fix #3, #4, #5

* Update Application.php

* Fix wrong response determined by content type delegation

* remove unused tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant