Allow for multiple fragments with the same ticket and type #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the fragment format to be <issue>.<type>(.<counter>) i.e have an optional .counter after the type.
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 93.37% 93.43% +0.06%
==========================================
Files 15 15
Lines 634 640 +6
Branches 64 65 +1
==========================================
+ Hits 592 598 +6
Misses 26 26
Partials 16 16
Continue to review full report at Codecov.
|
Cadair
added a commit
to Cadair/dkist
that referenced
this pull request
May 30, 2018
Cadair
force-pushed
the
multiple_fragments
branch
from
de07382
to
c64199e
Compare
Cadair
force-pushed
the
multiple_fragments
branch
from
c64199e
to
7196fab
Compare
|
@Cadair Could you write a changelog entry for this? :) |
|
done :) |
turt2live
added a commit
to turt2live/matrix-doc
that referenced
this pull request
Jul 12, 2018
Specifying multiple entries for the same PR would be covered under: twisted/towncrier#119
|
ping? 👼 Anything else that needs to happen on this? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the fragment format to be
<issue>.<type>(.<counter>)i.e have an optional.counterafter the type, which needs to be an integer.