Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only one websocket for all 'clients' #42

Closed
pilhuhn opened this issue Mar 23, 2016 · 1 comment
Closed

Use only one websocket for all 'clients' #42

pilhuhn opened this issue Mar 23, 2016 · 1 comment
Milestone

Comments

@pilhuhn
Copy link
Member

pilhuhn commented Mar 23, 2016

We now have websocket support in several places.
They should all be set up from the credentials passed to the unified client.

Only a single websocket should be setup between Hawkular server and the client gem and should
be (re)used by all the communication.

@pilhuhn pilhuhn added this to the 0.3 milestone Mar 23, 2016
@jkremser
Copy link
Member

jkremser commented May 9, 2016

I've actually done it for operations here https://git.io/vrezU I forgot to close this issue.

note: The inventory can have also the websocket connection to listen on the inventory events, but this connection can't be shared with the connection for the operations, because there is a different endpoint for it on the Hawkular side. The connections for the inventory events can't be easily shared w/ the current hawkular impl, because part of the endpoint URL is the query (https://git.io/vrezc). That may change, but it'd require to establish some kind of simple protocol on top of WS layer to be able to express what data we want (similarly to the operations@cmdgw)

@jkremser jkremser closed this as completed May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants