Use jUnit assert*() rather than java assert in pinger tests and minor

tests polishing
hawkular · May 13, 2015 · 2c2a3c5 · 2c2a3c5
1 parent f23593f
commit 2c2a3c5
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/modules/pinger/src/test/java/org/hawkular/component/pinger/test/PingerTest.java b/modules/pinger/src/test/java/org/hawkular/component/pinger/test/PingerTest.java
@@ -25,6 +25,7 @@
 import org.hawkular.component.pinger.PingStatus;
 import org.hawkular.component.pinger.Pinger;
 import org.hawkular.metrics.client.common.SingleMetric;
+import org.junit.Assert;
 import org.junit.Test;
 
 /**
@@ -34,27 +35,27 @@
  */
 public class PingerTest {
 
-    @org.junit.Test
+    @Test
     public void testPinger() throws Exception {
 
         Pinger pinger = new Pinger();
         PingDestination destination = new PingDestination("123","http://hawkular.github.io");
         PingStatus status = pinger.ping(new PingStatus(destination)).get();
 
-        assert status.getCode()==200;
-        assert status.isTimedOut()==false;
+        Assert.assertEquals(200, status.getCode());
+        Assert.assertFalse(status.isTimedOut());
 
     }
 
-    @org.junit.Test
+    @Test
     public void testSslPinger() throws Exception {
 
         Pinger pinger = new Pinger();
         PingDestination destination = new PingDestination("123","https://www.perfcake.org");
         PingStatus status = pinger.ping(new PingStatus(destination)).get();
 
-        assert status.getCode()==200;
-        assert status.isTimedOut()==false;
+        Assert.assertEquals(200, status.getCode());
+        Assert.assertFalse(status.isTimedOut());
     }
 
     @Test
@@ -95,7 +96,7 @@ public void testPingManagerStartup() throws Exception {
     }
 
 
-    private class NoOpMetricPublisher extends MetricPublisher {
+    private static class NoOpMetricPublisher extends MetricPublisher {
         @Override
         public void sendToMetricsViaRest(String tenantId, List<Map<String, Object>> metrics) {