HAWKULAR-442 fixing remaining tslint rules

hawkular · Jul 9, 2015 · 867dac0 · 867dac0
1 parent 023eced
commit 867dac0
Show file tree

Hide file tree

Showing 15 changed files with 64 additions and 64 deletions.
diff --git a/console/src/main/scripts/plugins/accounts/ts/accountsGlobals.ts b/console/src/main/scripts/plugins/accounts/ts/accountsGlobals.ts
@@ -17,7 +17,7 @@
 
 /// <reference path="../../includes.ts"/>
 module HawkularAccounts {
-    export var pluginName = "hawkular-accounts";
+    export var pluginName = 'hawkular-accounts';
     export var log:Logging.Logger = Logger.get(pluginName);
-    export var templatePath = "plugins/accounts/html";
+    export var templatePath = 'plugins/accounts/html';
 }
diff --git a/console/src/main/scripts/plugins/accounts/ts/accountsPlugin.ts b/console/src/main/scripts/plugins/accounts/ts/accountsPlugin.ts
@@ -15,8 +15,8 @@
 /// limitations under the License.
 ///
 
-/// <reference path="../../includes.ts"/>
-/// <reference path="accountsGlobals.ts"/>
+/// <reference path='../../includes.ts'/>
+/// <reference path='accountsGlobals.ts'/>
 module HawkularAccounts {
     export var _module = angular.module(HawkularAccounts.pluginName, ['ui.bootstrap']);
     var accountsTab:any = undefined;
@@ -27,10 +27,10 @@ module HawkularAccounts {
         builder:HawtioMainNav.BuilderFactory) => {
         accountsTab = builder.create()
             .id(HawkularAccounts.pluginName)
-            .title(() => "Accounts")
-            .href(() => "/accounts")
-            .subPath("My account", "accounts", builder.join(HawkularAccounts.templatePath, 'accounts.html'))
-            .subPath("Organizations", "organizations", builder.join(HawkularAccounts.templatePath,
+            .title(() => 'Accounts')
+            .href(() => '/accounts')
+            .subPath('My account', 'accounts', builder.join(HawkularAccounts.templatePath, 'accounts.html'))
+            .subPath('Organizations', 'organizations', builder.join(HawkularAccounts.templatePath,
                 'organizations.html'))
             .build();
         builder.configureRouting($routeProvider, accountsTab);
@@ -51,7 +51,7 @@ module HawkularAccounts {
         });
 
         $rootScope.$on('IdleEnd', () => {
-            $("#idle").slideUp();
+            $('#idle').slideUp();
         });
 
         $rootScope.$on('IdleTimeout', () => {
@@ -62,7 +62,7 @@ module HawkularAccounts {
                 backdrop: 'static'
             });
         });
-        
+
         $rootScope.$on('CurrentPersonaLoaded', (e, persona) => {
             currentPersona = persona;
             $rootScope.currentPersona = currentPersona;
@@ -75,7 +75,7 @@ module HawkularAccounts {
     }]);
 
     hawtioPluginLoader.registerPreBootstrapTask((next) => {
-        window['KeycloakConfig'] = "/keycloak.json";
+        window['KeycloakConfig'] = '/keycloak.json';
         next();
     }, true);
 

diff --git a/console/src/main/scripts/plugins/accounts/ts/organizations.ts b/console/src/main/scripts/plugins/accounts/ts/organizations.ts
@@ -15,10 +15,10 @@
 /// limitations under the License.
 ///
 
-/// <reference path="accountsPlugin.ts"/>
+/// <reference path='accountsPlugin.ts'/>
 module HawkularAccounts {
 
-    export var OrganizationsController = _module.controller("HawkularAccounts.OrganizationsController", [
+    export var OrganizationsController = _module.controller('HawkularAccounts.OrganizationsController', [
         '$rootScope', '$scope', '$log', '$location', 'HawkularAccount',
         ($rootScope, $scope, $log, $location, HawkularAccount) => {
 
@@ -37,7 +37,7 @@ module HawkularAccounts {
                         $scope.loading = false;
                     },
                     () => {
-                        $log.warn("List of organizations could NOT be retrieved.");
+                        $log.warn('List of organizations could NOT be retrieved.');
                         $scope.loading = false;
                     }
                 );
@@ -61,7 +61,7 @@ module HawkularAccounts {
             });
         }]);
 
-    export var OrganizationNewController = _module.controller("HawkularAccounts.OrganizationNewController", [
+    export var OrganizationNewController = _module.controller('HawkularAccounts.OrganizationNewController', [
         '$scope', '$log', '$location', 'HawkularAccount',
         ($scope, $log, $location, HawkularAccount) => {
 
@@ -74,10 +74,10 @@ module HawkularAccounts {
                     },
                     () => {
                         // error
-                        $log.debug("Organization could NOT be added.");
+                        $log.debug('Organization could NOT be added.');
                     }
                 );
-                $log.debug("Trying to persist the organization");
+                $log.debug('Trying to persist the organization');
             };
         }]);
 }
diff --git a/console/src/main/scripts/plugins/accounts/ts/persona.ts b/console/src/main/scripts/plugins/accounts/ts/persona.ts
@@ -15,10 +15,10 @@
 /// limitations under the License.
 ///
 
-/// <reference path="accountsPlugin.ts"/>
+/// <reference path='accountsPlugin.ts'/>
 module HawkularAccounts {
 
-    export var PersonaController = _module.controller("HawkularAccounts.PersonaController", [
+    export var PersonaController = _module.controller('HawkularAccounts.PersonaController', [
         '$rootScope', '$scope', '$log', 'HawkularAccount',
         ($rootScope, $scope, $log, HawkularAccount) => {
             $scope.personas = [];
@@ -29,12 +29,12 @@ module HawkularAccounts {
             };
 
             $scope.loadCurrentPersona = () => {
-                $scope.currentPersona = HawkularAccount.Persona.get({id: "current"},
+                $scope.currentPersona = HawkularAccount.Persona.get({id: 'current'},
                     () => {
-                        $scope.$emit("CurrentPersonaLoaded", $scope.currentPersona);
+                        $scope.$emit('CurrentPersonaLoaded', $scope.currentPersona);
                     },
                     () => {
-                        $log.warn("Failed in retrieving the current persona");
+                        $log.warn('Failed in retrieving the current persona');
                     }
                 );
             };
@@ -48,7 +48,7 @@ module HawkularAccounts {
                         $scope.loading = false;
                     },
                     () => {
-                        $log.warn("List of personas could NOT be retrieved.");
+                        $log.warn('List of personas could NOT be retrieved.');
                         $scope.loading = false;
                     }
                 );
@@ -60,7 +60,7 @@ module HawkularAccounts {
                 $scope.personas = $scope.personas.filter((persona) => {
                     return persona.id !== $scope.currentPersona.id;
                 });
-                $scope.$emit("SwitchedPersona", persona);
+                $scope.$emit('SwitchedPersona', persona);
             };
 
             $rootScope.$on('CurrentPersonaLoaded', () => {

diff --git a/console/src/main/scripts/plugins/directives/alert/ts/alertGlobals.ts b/console/src/main/scripts/plugins/directives/alert/ts/alertGlobals.ts
@@ -15,9 +15,9 @@
 /// limitations under the License.
 ///
 
-/// <reference path="../../includes.ts"/>
+/// <reference path='../../includes.ts'/>
 module Alert {
 
-  export var pluginName = "hawkular-alerts";
+  export var pluginName = 'hawkular-alerts';
 
 }
diff --git a/console/src/main/scripts/plugins/directives/sidebar/ts/sidebarDirective.ts b/console/src/main/scripts/plugins/directives/sidebar/ts/sidebarDirective.ts
@@ -15,10 +15,10 @@
 /// limitations under the License.
 ///
 
-/// <reference path="sidebarPlugin.ts"/>
+/// <reference path='sidebarPlugin.ts'/>
 module Sidebar {
 
-  var log:Logging.Logger = Logger.get("Sidebar");
+  var log:Logging.Logger = Logger.get('Sidebar');
 
   export class SidebarDirective {
 
@@ -30,7 +30,7 @@ module Sidebar {
   }
 
   /*
-  export var SidebarController = _module.controller("Sidebar.SidebarController",
+  export var SidebarController = _module.controller('Sidebar.SidebarController',
     ['$scope', '$rootScope', '$location', ($scope, $rootScope, $location) => {
 
       $scope.isSinglePage = function() {
@@ -43,7 +43,7 @@ module Sidebar {
     }]);
   */
 
-  export var SidebarController = _module.controller("Sidebar.SidebarController",
+  export var SidebarController = _module.controller('Sidebar.SidebarController',
       ['$scope', '$rootScope', '$location', 'HawkularNav', 'HawkularInventory', ($scope, $rootScope, $location,
                                                                                  HawkularNav, HawkularInventory) => {
 

diff --git a/console/src/main/scripts/plugins/directives/sidebar/ts/sidebarGlobals.ts b/console/src/main/scripts/plugins/directives/sidebar/ts/sidebarGlobals.ts
@@ -15,14 +15,14 @@
 /// limitations under the License.
 ///
 
-/// <reference path="../../includes.ts"/>
+/// <reference path='../../includes.ts'/>
 module Sidebar {
 
-  export var pluginName = "sidebar";
+  export var pluginName = 'sidebar';
 
   export var log:Logging.Logger = Logger.get(pluginName);
 
-  export var templatePath = "plugins/directives/sidebar/html/sidebar.html";
+  export var templatePath = 'plugins/directives/sidebar/html/sidebar.html';
 
-  export var globalEnvironmentId = "test";
+  export var globalEnvironmentId = 'test';
 }
diff --git a/console/src/main/scripts/plugins/directives/topbar/ts/topbarDirective.ts b/console/src/main/scripts/plugins/directives/topbar/ts/topbarDirective.ts
@@ -15,10 +15,10 @@
 /// limitations under the License.
 ///
 
-/// <reference path="topbarPlugin.ts"/>
+/// <reference path='topbarPlugin.ts'/>
 module Topbar {
 
-  var log:Logging.Logger = Logger.get("Topbar");
+  var log:Logging.Logger = Logger.get('Topbar');
 
   export class TopbarDirective {
 
@@ -29,7 +29,7 @@ module Topbar {
     public templateUrl = templatePath;
   }
 
-  export var TopbarController = _module.controller("Topbar.TopbarController",
+  export var TopbarController = _module.controller('Topbar.TopbarController',
     ['$scope', '$rootScope', '$location', '$route', '$routeParams', 'HawkularNav', 'HawkularInventory',
       ($scope, $rootScope, $location, $route, $routeParams, HawkularNav, HawkularInventory) => {
 

diff --git a/console/src/main/scripts/plugins/directives/topbar/ts/topbarGlobals.ts b/console/src/main/scripts/plugins/directives/topbar/ts/topbarGlobals.ts
@@ -15,15 +15,15 @@
 /// limitations under the License.
 ///
 
-/// <reference path="../../includes.ts"/>
+/// <reference path='../../includes.ts'/>
 module Topbar {
 
-  export var pluginName = "topbar";
+  export var pluginName = 'topbar';
 
   export var log:Logging.Logger = Logger.get(pluginName);
 
-  export var templatePath = "plugins/directives/topbar/html/topbar.html";
+  export var templatePath = 'plugins/directives/topbar/html/topbar.html';
 
-  export var globalEnvironmentId = "test";
+  export var globalEnvironmentId = 'test';
 
 }
diff --git a/console/src/main/scripts/plugins/metrics/ts/addUrlPage.ts b/console/src/main/scripts/plugins/metrics/ts/addUrlPage.ts
@@ -15,10 +15,10 @@
 /// limitations under the License.
 ///
 
-/// <reference path="metricsPlugin.ts"/>
-/// <reference path="alertsManager.ts"/>
-/// <reference path="pagination.ts"/>
-/// <reference path="errorManager.ts"/>
+/// <reference path='metricsPlugin.ts'/>
+/// <reference path='alertsManager.ts'/>
+/// <reference path='pagination.ts'/>
+/// <reference path='errorManager.ts'/>
 
 module HawkularMetrics {
 

diff --git a/console/src/main/scripts/plugins/metrics/ts/metricsAvailabilityPage.ts b/console/src/main/scripts/plugins/metrics/ts/metricsAvailabilityPage.ts
@@ -15,9 +15,9 @@
 /// limitations under the License.
 ///
 
-/// <reference path="metricsTypes.ts"/>
-/// <reference path="metricsPlugin.ts"/>
-/// <reference path="../../includes.ts"/>
+/// <reference path='metricsTypes.ts'/>
+/// <reference path='metricsPlugin.ts'/>
+/// <reference path='../../includes.ts'/>
 
 module HawkularMetrics {
 
@@ -145,7 +145,7 @@ module HawkularMetrics {
           buckets: 1
         }).$promise
           .then((availResponse:IAvailabilitySummary[]) => {
-            console.info("Avail Summary:");
+            console.info('Avail Summary:');
             console.dir(availResponse);
 
             if (availResponse && !_.last(availResponse).empty) {
@@ -179,7 +179,7 @@ module HawkularMetrics {
         }).$promise
           .then((response) => {
 
-            console.log("Availability Data: ");
+            console.log('Availability Data: ');
             console.dir(response);
             this.availabilityDataPoints = response;
 

diff --git a/console/src/main/scripts/plugins/metrics/ts/metricsGlobals.ts b/console/src/main/scripts/plugins/metrics/ts/metricsGlobals.ts
@@ -15,20 +15,20 @@
 /// limitations under the License.
 ///
 
-/// <reference path="../../includes.ts"/>
+/// <reference path='../../includes.ts'/>
 
 module HawkularMetrics {
 
   /// some config vars
-  export var pluginName = "hawkular-metrics";
+  export var pluginName = 'hawkular-metrics';
 
   export var log:Logging.Logger = Logger.get(pluginName);
 
-  export var templatePath = "plugins/metrics/html";
+  export var templatePath = 'plugins/metrics/html';
 
 
   /// These are plugin globals used across several screens (think session vars from server side programming)
 
-  export var globalEnvironmentId = "test";
+  export var globalEnvironmentId = 'test';
 
 }
diff --git a/console/src/main/scripts/plugins/metrics/ts/metricsPlugin.ts b/console/src/main/scripts/plugins/metrics/ts/metricsPlugin.ts
@@ -15,8 +15,8 @@
 /// limitations under the License.
 ///
 
-/// <reference path="../../includes.ts"/>
-/// <reference path="metricsGlobals.ts"/>
+/// <reference path='../../includes.ts'/>
+/// <reference path='metricsGlobals.ts'/>
 
 module HawkularMetrics {
 
@@ -106,7 +106,7 @@ module HawkularMetrics {
         return window['encodeURIComponent'];
     });
 
-    _module.config(["$routeProvider", ($routeProvider) => {
+    _module.config(['$routeProvider', ($routeProvider) => {
         $routeProvider.
             // this was for single page.. remove ?
             when('/hawkular/:resourceId/:timeOffset?/:endTime?',

diff --git a/console/src/main/scripts/plugins/metrics/ts/metricsResponsePage.ts b/console/src/main/scripts/plugins/metrics/ts/metricsResponsePage.ts
@@ -15,9 +15,9 @@
 /// limitations under the License.
 ///
 
-/// <reference path="metricsTypes.ts"/>
-/// <reference path="metricsPlugin.ts"/>
-/// <reference path="../../includes.ts"/>
+/// <reference path='metricsTypes.ts'/>
+/// <reference path='metricsPlugin.ts'/>
+/// <reference path='../../includes.ts'/>
 
 module HawkularMetrics {
 
@@ -101,7 +101,7 @@ module HawkularMetrics {
           this.refreshChartDataNow(this.getMetricId());
         }
       });
-      
+
       if ($rootScope.currentPersona) {
         waitForResourceId();
       } else {

diff --git a/console/src/main/scripts/tslint.json b/console/src/main/scripts/tslint.json
@@ -7,7 +7,7 @@
     "indent": [true, "spaces"],
     "label-position": true,
     "label-undefined": true,
-    "_max-line-length": [true, 140],
+    "max-line-length": [true, 120],
     "no-arg": true,
     "no-bitwise": true,
     "no-console": [true,
@@ -22,7 +22,7 @@
     "no-string-literal": false,
     "no-switch-case-fall-through": true,
     "no-trailing-comma": true,
-    "_no-trailing-whitespace": true,
+    "no-trailing-whitespace": true,
     "no-unused-expression": true,
     "no-unused-variable": false,
     "no-unreachable": true,
@@ -33,7 +33,7 @@
       "check-else",
       "check-whitespace"
     ],
-    "_quotemark": [true, "double"],
+    "quotemark": [true, "single"],
     "radix": true,
     "semicolon": true,
     "triple-equals": [true, "allow-null-check"],