Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Commit

Permalink
HAWKULAR-400 : Redirect to URL/App Server list when resource not found
Browse files Browse the repository at this point in the history 
Also includes some cleanup to metricsPlugin.ts
  • Loading branch information
@ammendonca
ammendonca committed Jul 9, 2015
1 parent efb4e47 commit d4650fb
Show file tree
Hide file tree
Showing 3 changed files with 103 additions and 61 deletions.
2 changes: 1 addition & 1 deletion console/src/main/scripts/plugins/metrics/html/app-server-list.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ <h1>No application servers set up.</h1>
<p ng-hide="res.state"><span class="spinner spinner-sm spinner-inline"></span> <span class="fetching">Fetching state...</span></p>
{{res.state | firstUpper}}
</td>
<td><a href="/hawkular-ui/app/app-details/{{res.id | limitTo14 : res.id.length-4 : 1}}/jvm">{{res.id | limitTo14 : res.id.length-4 : 1}}</a> <a href="/hawkular-ui/app/app-details/{{res.id | urlEncode}}/jvm" class="pull-right"><span class="label label-danger label-alert" tooltip-trigger tooltip-placement="top" tooltip="Server alerts" ng-show="res.alerts.length > 0">{{res.alerts.length}}</span></a></td>
<td><a href="/hawkular-ui/app/app-details/{{res.id | limitTo14 : res.id.length-4 : 1}}/jvm">{{res.id | limitTo14 : res.id.length-4 : 1}}</a> <a href="/hawkular-ui/app/app-details/{{res.id}}/jvm" class="pull-right"><span class="label label-danger label-alert" tooltip-trigger tooltip-placement="top" tooltip="Server alerts" ng-show="res.alerts.length > 0">{{res.alerts.length}}</span></a></td>
<td>{{res.type.id}}</td>
<td>{{(res.properties.resourceConfiguration | filter:'Hostname':true)[0].value || 'n/a'}}</td>
<!-- <td class="center"><span class="label label-primary" ng-repeat="tag in res.tags">{{tag}}</span><span ng-hide="res.tags.length > 0">--</span></td> -->
Expand Down
3 changes: 3 additions & 0 deletions console/src/main/scripts/plugins/metrics/ts/metricsGlobals.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,7 @@ module HawkularMetrics {

export var globalEnvironmentId = 'test';

/// This will be set when accessing a feed resource
export var globalFeedId = undefined;

}
159 changes: 99 additions & 60 deletions console/src/main/scripts/plugins/metrics/ts/metricsPlugin.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,53 +23,16 @@ module HawkularMetrics {
export var _module = angular.module(HawkularMetrics.pluginName, ['ngResource', 'ui.select', 'hawkular.charts',
'hawkular.services', 'ui.bootstrap', 'topbar', 'patternfly.select', 'angular-momentjs', 'angular-md5']);

var metricsTab:any;

_module.config(['$httpProvider', '$locationProvider', '$routeProvider', 'HawtioNavBuilderProvider',
($httpProvider, $locationProvider, $routeProvider:ng.route.IRouteProvider,
navBuilder:HawtioMainNav.BuilderFactory) => {

metricsTab = navBuilder.create()
.id(HawkularMetrics.pluginName)
.title(() => 'Metrics')
.href(() => '/metrics')
.subPath('Add Url', 'add-url', navBuilder.join(HawkularMetrics.templatePath, 'add-url.html'))
.subPath('Response Time', 'response-time', navBuilder.join(HawkularMetrics.templatePath,
'response-time.html'))
.subPath('Availability', 'availability', navBuilder.join(HawkularMetrics.templatePath, 'availability.html'))
.subPath('Alerts', 'alerts', navBuilder.join(HawkularMetrics.templatePath, 'alerts.html'))
.build();

navBuilder.configureRouting($routeProvider, metricsTab);

_module.config(['$httpProvider', '$locationProvider', '$routeProvider', ($httpProvider, $locationProvider, $routeProvider:ng.route.IRouteProvider) => {
$locationProvider.html5Mode(true);
}]);

_module.run(['HawtioNav', (HawtioNav:HawtioMainNav.Registry) => {
HawtioNav.add(metricsTab);
log.debug('loaded Metrics Plugin');
}]);

_module.directive('hkEnter', () => {
return function (scope, element, attrs) {
element.bind('keydown keypress', (event) => {
if (event.which === 13) {
scope.$apply(() => {
scope.$eval(attrs.hkEnter);
});

event.preventDefault();
}
});
};
});

_module.filter('firstUpper', function () {
return function (input, all) {
return (!!input) ? input.replace(/([^\W_]+[^\s-]*) */g, function (txt) {
return txt.charAt(0).toUpperCase() + txt.substr(1);
}) : '';
};
return function (input, all) {
return (!!input) ? input.replace(/([^\W_]+[^\s-]*) */g, function (txt) {
return txt.charAt(0).toUpperCase() + txt.substr(1);
}) : '';
};
});

/**
Expand Down Expand Up @@ -102,15 +65,10 @@ module HawkularMetrics {
};
});

_module.filter('urlEncode', function () {
return window['encodeURIComponent'];
});

_module.config(['$routeProvider', ($routeProvider) => {
$routeProvider.
// this was for single page.. remove ?
when('/hawkular/:resourceId/:timeOffset?/:endTime?',
{templateUrl: 'plugins/metrics/html/single-page.html'}).
when('/hawkular/:resourceId/:timeOffset?/:endTime?', {templateUrl: 'plugins/metrics/html/single-page.html'}).
when('/metrics/response-time', {
templateUrl: 'plugins/metrics/html/response-time.html',
resolve: {
Expand All @@ -131,21 +89,102 @@ module HawkularMetrics {
}
}).
when('/hawkular-ui/url/url-list', {templateUrl: 'plugins/metrics/html/add-url.html'}).
when('/hawkular-ui/url/response-time/:resourceId/:timeOffset?/:endTime?',
{templateUrl: 'plugins/metrics/html/response-time.html'}).
when('/hawkular-ui/url/availability/:resourceId/:timeOffset?/:endTime?',
{templateUrl: 'plugins/metrics/html/availability.html'}).
when('/hawkular-ui/url/alerts/:resourceId/:timeOffset?/:endTime?',
{templateUrl: 'plugins/metrics/html/alerts.html'}).

when('/hawkular-ui/url/response-time/:resourceId/:timeOffset?/:endTime?', {
templateUrl: 'plugins/metrics/html/response-time.html',
reloadOnSearch: false,
resolve: {
resource: function ($route, $location, HawkularInventory) {
var p = HawkularInventory.Resource.get({environmentId: globalEnvironmentId,
resourceId: $route.current.params.resourceId}).$promise;
p.then((response) => {
return response.properties.url;
},
(error) => {
toastr.info('You were redirected to this page because you requested an invalid URL.');
$location.path('/');
});
return p;
}
}
}).
when('/hawkular-ui/url/availability/:resourceId/:timeOffset?/:endTime?', {
templateUrl: 'plugins/metrics/html/availability.html',
reloadOnSearch: false,
resolve: {
resource: function ($route, $location, HawkularInventory) {
var p = HawkularInventory.Resource.get({environmentId: globalEnvironmentId,
resourceId: $route.current.params.resourceId}).$promise;
p.then((response) => {
return response.properties.url;
},
(error) => {
toastr.info('You were redirected to this page because you requested an invalid URL.');
$location.path('/');
});
return p;
}
}
}).
when('/hawkular-ui/url/alerts/:resourceId/:timeOffset?/:endTime?', {
templateUrl: 'plugins/metrics/html/alerts.html',
reloadOnSearch: false,
resolve: {
resource: function ($route, $location, HawkularInventory) {
var p = HawkularInventory.Resource.get({environmentId: globalEnvironmentId,
resourceId: $route.current.params.resourceId}).$promise;
p.then((response) => {
return response.properties.url;
},
(error) => {
toastr.info('You were redirected to this page because you requested an invalid URL.');
$location.path('/');
});
return p;
}
}
}).
when('/hawkular-ui/app/app-list', {templateUrl: 'plugins/metrics/html/app-server-list.html'}).
when('/hawkular-ui/app/app-details/:resourceId/:tabId/:timeOffset?/:endTime?', {
templateUrl: 'plugins/metrics/html/app-details/app-server-details.html',
resolve: {
hideSubNav: function () {
return true;
templateUrl: 'plugins/metrics/html/app-details/app-server-details.html',
reloadOnSearch: false,
resolve: {
resource: function ($route, $location, HawkularInventory) {
var redirectMissingAppServer = function() {
toastr.info('You were redirected to this page because you requested an invalid Application Server.');
$location.path('/hawkular-ui/app/app-list');
};
var checkAppServerExists = function() {
var p = HawkularInventory.FeedResource.get({
environmentId: globalEnvironmentId,
feedId: globalFeedId,
resourceId: '[' + $route.current.params.resourceId + '~/]'
}).$promise;
p.then((response) => {
return response;
},
(error) => redirectMissingAppServer()
);
return p;
};
var isValidAppServer = function() {
if (!globalFeedId) {
return HawkularInventory.Feed.query({environmentId: globalEnvironmentId}).$promise
.then((response) => {
globalFeedId = response.length && response[0].id;
if (globalFeedId) {
return checkAppServerExists();
}
}
/*,
(error) => redirectMissingAppServer()*/
);
} else {
return checkAppServerExists();
}
};
return isValidAppServer();
}
}
}).
otherwise({redirectTo: '/hawkular-ui/url/url-list'});
}]);
Expand Down

0 comments on commit d4650fb

Please sign in to comment.