Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

HAWKULAR-28: Initial prototype for Angular Sidebar menu directive #41

Closed
wants to merge 1 commit into from

Conversation

ammendonca
Copy link
Contributor

No description provided.

@mtho11
Copy link
Member

mtho11 commented Mar 5, 2015

Since we are nearing a release, I'm going to wait to merge this until after the release.

Also, I think the dual navigation could be confusing and needs further discussion with the UXD folks. We can have that talk on Monday's meeting.

I'm pretty sure sidebar navs should common at the plugin level(metrics, inventory, alerts) and not global. Or maybe only on Metrics not Inventory or Alerts. It is possible that UXD wants the sidebar navs to change at the individual page level though.

@mtho11 mtho11 self-assigned this Mar 5, 2015
@mtho11
Copy link
Member

mtho11 commented Mar 5, 2015

Another option could be to remove this from Hawkular Console and place the directives in hawkular-ui-components while eliminating all second level navigation for the plugin.

@mtho11
Copy link
Member

mtho11 commented Mar 5, 2015

sidebar-nav
Reference Image of sidebar nav.

@mtho11
Copy link
Member

mtho11 commented Mar 5, 2015

Ideally, having two cooperating directives would provide a very flexible solution.

<sidebarNav>
<navItem url="metrics/addUrl" label="Add Url" fa-font-image="" action="vm.addUrl()" />
<navItem url="metrics/addUrl" label="Add Url" fa-font-image="" action="vm.addUrl()" />

</sidebarNav>

I probably dont have all the correct properties or names, but just as example.

@theute
Copy link
Member

theute commented Mar 6, 2015

The home page when no URL has ever been entered should just have the URL input text (no navigation):
image

Then the left nav bar should appear and redirect to the "response" navigation entry with the content of http://localhost:8080/metrics/metricsResponse

It should not have top level bars. Alerts should be per URL (for now) and on the "alerts" side navigation bar. (Put all in there for now, dashboard, notifiers and definitions)
We should IMO even hide the inventory tab (an idea if we need access to it temporarily for development/testing is to put it on a URL such as localhost:8080/dev non visible to the user).

image

Once this is done, we'll be closer from the UXD reqs and we can share for comments, better split of what is "done" vs what is "temporary".

PS:We are missing a screen to CRUD Urls, in the meantime we can put a link in the very top bar, close to the username to add a new URL and present the same screen as on first call when no URL is present.

@ammendonca
Copy link
Contributor Author

This PR is now obsolete. New PRs have been made (hawkular/hawkular-ui-components#30 and #47).

@ammendonca ammendonca closed this Mar 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants