feat(bitfield): add .. to use all remaining bits #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When built with `RUSTFLAGS="--cfg trace_macros"`, the bitfield crate will now enable `trace_macros!`. This is useful for debugging macro bugs. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This fixes a bug where the `FromBits` impl for integers (e.g. `FromBits for u8`, etc) would erroneously consume _all_ remaining bits in the bitfield, rather than just the number of bits necessary for an integer of that type. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This commit adds support for `const NAME = ..;` in the bitfield macro to consume all remaining bits after previous subfields. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/bitfield-remaining
branch
from
b2f57ed
to
056bbb7
Compare
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
May 30, 2022
When built with `RUSTFLAGS="--cfg trace_macros"`, the bitfield crate will now enable `trace_macros!`. This is useful for debugging macro bugs. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
May 30, 2022
This fixes a bug where the `FromBits` impl for integers (e.g. `FromBits for u8`, etc) would erroneously consume _all_ remaining bits in the bitfield, rather than just the number of bits necessary for an integer of that type. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
May 30, 2022
This commit adds support for `const NAME = ..;` in the bitfield macro to consume all remaining bits after previous subfields. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.