feat(cordyceps): add List::{front, back, front_mut, back_mut}
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch adds accessors for the front and back elements of a `cordyceps::List`. The returned elements are `Pin`ned to prevent them from being moved out of the list. The `Pin`ning was not strictly necessary for the immutable accessors but I did it for consistency with the mutable ones...we _could_ safely just have those return `&T`, though.
jamesmunns
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds accessors for the front and back elements of a
cordyceps::List. The returned elements arePinned to prevent themfrom being moved out of the list. The
Pinning was not strictlynecessary for the immutable accessors but I did it for consistency with
the mutable ones...we could safely just have those return
&T,though.