feat(cordyceps): add some list surgery methods #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
The `fmt::Debug` impl for `List` didn't include the length. This fixes that. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 19, 2022
This commit adds a `List::split_off` method to `cordyceps::List`, similar to the one on `std::collections::LinkedList`. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 19, 2022
This commit adds `split_before` and `split_after` methods to `cordyceps::list::Cursor`, similar to the ones on `std::collections::linked_list::CursorMut`. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/list-surgery
branch
from
a0ebde5
to
07420a8
Compare
This commit adds a `List::split_off` method to `cordyceps::List`, similar to the one on `std::collections::LinkedList`. Additionally, it adds a `try_split_off` method that doesn't panic if the split index is greater than the list's length, and returns an `Option` instead --- `std::collections::LinkedList` doesn't have this, but I thought it was kinda nice. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This commit adds `split_before` and `split_after` methods to `cordyceps::list::Cursor`, similar to the ones on `std::collections::linked_list::CursorMut`. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/list-surgery
branch
from
07420a8
to
a60bcb4
Compare
hawkw
added a commit
that referenced
this pull request
Jun 20, 2022
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 20, 2022
The `fmt::Debug` impl for `List` didn't include the length. This fixes that. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 20, 2022
This commit adds a `List::split_off` method to `cordyceps::List`, similar to the one on `std::collections::LinkedList`. Additionally, it adds a `try_split_off` method that doesn't panic if the split index is greater than the list's length, and returns an `Option` instead --- `std::collections::LinkedList` doesn't have this, but I thought it was kinda nice. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 21, 2022
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 21, 2022
The `fmt::Debug` impl for `List` didn't include the length. This fixes that. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 21, 2022
This commit adds a `List::split_off` method to `cordyceps::List`, similar to the one on `std::collections::LinkedList`. Additionally, it adds a `try_split_off` method that doesn't panic if the split index is greater than the list's length, and returns an `Option` instead --- `std::collections::LinkedList` doesn't have this, but I thought it was kinda nice. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 21, 2022
This commit adds `split_before` and `split_after` methods to `cordyceps::list::Cursor`, similar to the ones on `std::collections::linked_list::CursorMut`. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
List::append,List::split_off, andCursor::split_before/split_after.