fix(cordyceps): pin CursorMut iterator Items
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `Item` type of `list::CursorMut`'s `Iterator` impl is `&mut T`. This is incorrect, as it allows the items to be moved out of the list without unlinking them. Instead, the iterator's item type must be `Pin`ned. PR #209 made this change for the `IterMut` type, but did not make the same change for `CursorMut`, so this commit fixes `CursorMut` similarly. BREAKING CHANGE: This changes the type signature of the `Iterator` impl for `list::CursorMut`.
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 23, 2022
This branch adds an immutable cursor to `cordyceps::list`, in addition to the existing mutable cursor. This functions similarly to the `std::collections::linked_list::Cursor` type. Depends on #240.
hawkw
added a commit
that referenced
this pull request
Jun 23, 2022
This branch adds an immutable cursor to `cordyceps::list`, in addition to the existing mutable cursor. This functions similarly to the `std::collections::linked_list::Cursor` type. Depends on #240.
hawkw
added a commit
that referenced
this pull request
Jun 23, 2022
This branch adds an immutable cursor to `cordyceps::list`, in addition to the existing mutable cursor. This functions similarly to the `std::collections::linked_list::Cursor` type. Depends on #240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Itemtype oflist::CursorMut'sIteratorimpl is&mut T. This is incorrect, as it allows the items to be moved out ofthe list without unlinking them. Instead, the iterator's item type must
be
Pinned. PR #209 made this change for theIterMuttype, but didnot make the same change for
CursorMut, so this commit fixesCursorMutsimilarly.BREAKING CHANGE:
This changes the type signature of the
Iteratorimpl forlist::CursorMut.