misc buddy allocator improvements + fixes #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obviously, you can't remove a node from a list that's empty. This commit adds a `debug_assert!` to ensure this doesn't happen.
This fixes a bug in the buddy allocator where a block's buddy is calculated wrongly. This resulted in an issue where we tried to remove a block (which we *believed* was the current block's buddy) from the free list for that order, but the block was actually on a different free list.
This changes the `buddy::Alloc` type to have a const generic parameter for the number of free lists, and construct the free list array internally. This is much nicer than having to pass in a type `L: AsRef<[spin::Mutex<List<Free>>]>`.
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jul 5, 2022
Obviously, you can't remove a node from a list that's empty. This commit adds a `debug_assert!` to ensure this doesn't happen.
hawkw
added a commit
that referenced
this pull request
Jul 5, 2022
This fixes a bug in the buddy allocator where a block's buddy is calculated wrongly. This resulted in an issue where we tried to remove a block (which we *believed* was the current block's buddy) from the free list for that order, but the block was actually on a different free list.
hawkw
added a commit
that referenced
this pull request
Jul 5, 2022
This changes the `buddy::Alloc` type to have a const generic parameter for the number of free lists, and construct the free list array internally. This is much nicer than having to pass in a type `L: AsRef<[spin::Mutex<List<Free>>]>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.