feat(cordyceps): add Stack and TransferStack
#434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
; Conflicts: ; Cargo.lock
hawkw
added
kind/enhancement
hawkw
added a commit
that referenced
this pull request
May 12, 2023
This branch adds an implementation of a singly-linked mutable FIFO `Stack`and a singly-linked lock-free FIFO `TransferStack` in `cordyceps::stack`. A `Stack` is just your traditional FIFO stack structure. `TransferStack` is a bit more interesting --- it's a simplification of the traditional lock-free Treiber stack wher all elements are popped into a new mutable `Stack` in a single atomic operation. This avoids the ABA problem issues common with naive Treiber stack implementations. It's intended primarily for use in a `mimalloc`-style sharded per-core memory allocator. Closes #137 Signed-off-by: Eliza Weisman <eliza@elizaswebsite>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds an implementation of a singly-linked mutable FIFO
Stackand a singly-linked lock-free FIFOTransferStackincordyceps::stack.A
Stackis just your traditional FIFO stack structure.TransferStackis a bit more interesting --- it's a simplification ofthe traditional lock-free Treiber stack wher all elements are popped
into a new mutable
Stackin a single atomic operation. This avoids theABA problem issues common with naive Treiber stack implementations. It's
intended primarily for use in a
mimalloc-style sharded per-core memoryallocator.
Closes #137