Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Observer" design pattern article doesn't credit author #97

Closed
matrefeytontias opened this issue Jan 16, 2018 · 1 comment
Closed

"Observer" design pattern article doesn't credit author #97

matrefeytontias opened this issue Jan 16, 2018 · 1 comment

Comments

@matrefeytontias
Copy link
Contributor

matrefeytontias commented Jan 16, 2018 •
edited
Loading

I wrote this article, which was merged some time ago after edits by @markknol , but I just realize now that the online article doesn't credit me at all. I believe it should list me as author, or at least contributor.
@markknol
Copy link
Member

markknol commented Jan 16, 2018 •
edited
Loading

Sorry! For some reason sometimes this wasn't picked up. Good news is you can 'claim' being the author, by just mentioning it in the article like this.

> Author: [matrefeytontias](https://github.com/matrefeytontias)

Update: I now disabled "Allow squash merging" which I think cause this. Ill added some notice for > Author: it in readme too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markknol @matrefeytontias