Label Generator is encoding the URL as a note, not a URL

[timdonovanuk]

First Check

• This is not a feature request
• I added a very descriptive title to this issue.
• I used the GitHub search to find a similar issue and didn't find it.
• I searched the documentation, with the integrated search.
• I already read the docs and didn't find an answer.

Homebox Version

https://homebox.fly.dev/reports/label-generator

What is the issue you are experiencing?

On my phone (samsung s23) it tries to open the URL's on that page as https%3A%2F%2Ftest.com%2Fa%2F000-001 so clearly something is wrong with encoding here.

How can the maintainer reproduce the issue?

Go to the demo site, open https://homebox.fly.dev/reports/label-generator, scan a QR code.

Deployment

Other

Deployment Details

No response

[avantegarde]

+1 I'm seeing this same behavior on the demo site along with my self hosted version. Both the label generator page as well as the qr codes being generated on individual item/asset pages are not encoded correctly.

[Smith3rman]

+1 I have the same problem on my side. The same problem happens in the Location QR-codes.

[bee-eater]

Same here! Anyone knows a quick fix?

[WoosterInitiative]

I'm happy to take a look at the code, but my biggest problem is always finding where in the code the thing is generated, specifically, what module generates the QR code? If someone can point me to it, I'm happy to take a crack at a PR; else, I just don't have the time to dig through all of the code.

[porteusconf]

I see backend/app/api/handlers/v1/v1_ctrl_qrcode.go imports go-qrcode from this git repo:
https://github.com/yeqown/go-qrcode which is active with only 5 issues at this time. So I may try to find out if the malformed URL is caused by go-qrcode or by homebox.

[jackwilsdon]

It appears that the issue is caused by the /qrcode URL generated by the frontend having double URL-encoded parameters:

https://homebox.fly.dev/api/v1/qrcode?data=https%253A%252F%252Fhomebox.fly.dev%252Fa%252F000-001

Decoding the data parameter once gives:

https://homebox.fly.dev/api/v1/qrcode?data=https%3A%2F%2Fhomebox.fly.dev%2Fa%2F000-001

Scanning the latter works fine. From a cursory glance at the frontend code, the issue appears to be in 2 places (label and item pages):

homebox/frontend/pages/reports/label-generator.vue

Line 181 in 0995478

return route(`/qrcode`, { data: encodeURIComponent(data) });

homebox/frontend/components/global/PageQRCode.vue

Line 23 in 0995478

return route(`/qrcode`, { data: encodeURIComponent(currentURL) });

The data property probably shouldn't be URL-encoded here, as that is already handled in the route function:

homebox/frontend/lib/api/base/urls.ts

Lines 22 to 36 in 0995478

	export function route(rest: string, params: Record<string, QueryValue> = {}): string {
	const url = new URL(parts.prefix + rest, parts.host);
	for (const [key, value] of Object.entries(params)) {
	if (Array.isArray(value)) {
	for (const item of value) {
	url.searchParams.append(key, String(item));
	}
	} else {
	url.searchParams.append(key, String(value));
	}
	}
	return url.toString().replace("http://localhost.com", "");
	}

Using url.searchParams encodes the parameters automatically, so the additional encodeURIComponent isn't needed:

const url = new URL("https://homebox.fly.dev/api/v1/qrcode");
url.searchParams.append("data", "https://homebox.fly.dev/a/000-001");
console.log(url.toString()); // https://homebox.fly.dev/api/v1/qrcode?data=https%3A%2F%2Fhomebox.fly.dev%2Fa%2F000-001

[Triple-Z]

same problem here, hope to see it solved in the next version ❤️