Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Aussie Dollar #92

Closed
3 tasks done
SavageAUS opened this issue Oct 16, 2022 · 1 comment · Fixed by #125
Closed
3 tasks done

Aussie Dollar #92

SavageAUS opened this issue Oct 16, 2022 · 1 comment · Fixed by #125

Comments

@SavageAUS
Copy link

What is the problem you are trying to solve with this feature?

Not enough currencies to choose from.

What is the solution you are proposing?

Add the aussie dollar

What alternatives have you considered?

No response

Additional context

No response

Contributions

  • I have searched through existing issues and feature requests to see if my idea has already been proposed.
  • If this feature is accepted, I would be willing to help implement and maintain this feature.
  • If this feature is accepted, I'm willing to sponsor the development of this feature.
@hay-kot
Copy link
Owner

hay-kot commented Oct 17, 2022

Hey! Would love to see this. Adding currencies should be fairly straight forward.

We need to add the enum type to the database here 👇 and then run task db:generate

Values("usd", "eur", "gbp", "jpy"), // TODO: add more currencies

Then add the corresponding entry to the frontend in this array

export const currencies: Currency[] = [
{
code: "USD",
local: "en-US",
symbol: "$",
name: "US Dollar",
},
{
code: "EUR",
local: "de-DE",
symbol: "€",
name: "Euro",
},
{
code: "GBP",
local: "en-GB",
symbol: "£",
name: "British Pound",
},
{
code: "JPY",
local: "ja-JP",
symbol: "¥",
name: "Japanese Yen",
},
];

Then it should just work. The problem I ran into was that it wasn't clear what the Intl API supported in the browser so could just copy a list of all the supported ones over.

@hay-kot hay-kot linked a pull request Nov 1, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants