New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-Module .set() .get() behaviour is not as expected #8

Closed
wellcaffeinated opened this Issue Jul 19, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@wellcaffeinated
Contributor

wellcaffeinated commented Jul 19, 2012

Hi

I love Stapes, but its submodule behaviour is really getting me down. I'm pretty sure this is a bug, and I'm pretty sure I know what's causing it.

Here's the test case
http://jsfiddle.net/wellcaffeinated/4RhTq/

I expect sub-modules to store their_own values (attributes) using .set(). But this is not the case.

I think what's going on is that when module.create() is called, the instance._guid (line: 243) is defined... it's inherited, so the sub-module doesn't get its own guid.

I'm trying to use Stapes in a few projects... I'd appreciate an official fix for this soon.

Cheers!

@hay

This comment has been minimized.

Show comment
Hide comment
@hay

hay Jul 20, 2012

Owner

Hey,
thanks for reporting this bug. I've noticed this a few days ago as well and it's already been fixed in this commit, so as a temporary fix you can get the latest version from master. I'll release a bugfix release soon.

Thanks for using Stapes!

-- Hay

Owner

hay commented Jul 20, 2012

Hey,
thanks for reporting this bug. I've noticed this a few days ago as well and it's already been fixed in this commit, so as a temporary fix you can get the latest version from master. I'll release a bugfix release soon.

Thanks for using Stapes!

-- Hay

@hay hay closed this Jul 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment