Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: patch git exec command #50

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Fix: patch git exec command #50

merged 4 commits into from
Dec 28, 2023

Conversation

xyhp915
Copy link
Contributor

@xyhp915 xyhp915 commented Dec 27, 2023

@xyhp915 xyhp915 mentioned this pull request Dec 27, 2023
Closed
@haydenull
Copy link
Owner

Excuse me, is the plugin loading normally on your computer? It has been stuck on loading on my side.

os：MacOS 14.4
logseq desktop: 0.10.3

CleanShot 2023-12-27 at 17 58 36@2x

@sidsarasvati
Copy link

Please fix! The plugin is totally broken

@dawaldow
Copy link

dawaldow commented Dec 27, 2023 •
edited
Loading

I am running Logseq 0.10.3 on Linux and when I click on the GIT icon, nothing happens. The console logs this ...
image

It works for 0.10.1, but nothing after that version. Command line GIT is working fine.

@xyhp915
Copy link
Contributor Author

xyhp915 commented Dec 28, 2023

Excuse me, is the plugin loading normally on your computer? It has been stuck on loading on my side.

os：MacOS 14.4
logseq desktop: 0.10.3

CleanShot 2023-12-27 at 17 58 36@2x

Maybe you have installed the same id plugin, please check logseq-git and uninstall it.

@xyhp915
Copy link
Contributor Author

xyhp915 commented Dec 28, 2023

I am running Logseq 0.10.3 on Linux and when I click on the GIT icon, nothing happens. The console logs this ...
image

It works for 0.10.1, but nothing after that version. Command line GIT is working fine.

Thanks for your feedback. This PR is for it.

@haydenull
Copy link
Owner

@xyhp915 Thank you for your efforts, I have tested and it is working fine.

@haydenull haydenull merged commit b4a4229 into haydenull:main Dec 28, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 28, 2023
@semantic-release-bot
chore(release): 1.5.5 [skip ci]
af47da5 
## [1.5.5](v1.5.4...v1.5.5) (2023-12-28)

### Bug Fixes

* patch git exec command ([#50](#50)) ([b4a4229](b4a4229))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.5.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dawaldow
Copy link

🎉 This PR is included in version 1.5.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Thank you! Logseq found the update this morning and installed. Issue resolved. Thanks for your support and care/feeding of this product!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
4 participants
@xyhp915 @haydenull @sidsarasvati @dawaldow