breaking: you can no-longer define args on 'exposed' fields

hayes · Feb 7, 2021 · 240162b · 240162b
1 parent fcb1f76
commit 240162b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/packages/core/src/fieldUtils/builder.ts b/packages/core/src/fieldUtils/builder.ts
@@ -100,7 +100,7 @@ export default class FieldBuilder<
         ParentShape,
         ResolveReturnShape
       >,
-      'resolve' | 'type'
+      'resolve' | 'type' | 'args'
     >,
   ) {
     return this.exposeField<'Int', Nullable, Name>(name, { ...options, type: 'Int' });

diff --git a/packages/plugin-scope-auth/src/types.ts b/packages/plugin-scope-auth/src/types.ts
@@ -1,18 +1,18 @@
-import { MaybePromise, SchemaTypes } from '@giraphql/core';
+import { MaybePromise, Merge, SchemaTypes } from '@giraphql/core';
 import { GraphQLResolveInfo } from 'graphql';
 
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface ScopeAuthPluginOptions {}
 
 export interface BuiltInScopes<Types extends SchemaTypes> {
-  $all: AuthScopeMap<Types>;
-  $any: AuthScopeMap<Types>;
-  $granted: string[];
+  $all?: true extends true ? AuthScopeMap<Types> : never;
+  $any?: true extends true ? AuthScopeMap<Types> : never;
+  $granted?: string[];
 }
 
-export type AuthScopeMap<Types extends SchemaTypes> = {
-  [K in keyof (Types['AuthScopes'] | BuiltInScopes<Types>)]?: Types['AuthScopes'][K];
-};
+export type AuthScopeMap<Types extends SchemaTypes> = Merge<
+  Partial<Types['AuthScopes']> & BuiltInScopes<Types>
+>;
 
 export type ScopeAuthInitializer<Types extends SchemaTypes> = (
   context: Types['Context'],
@@ -35,7 +35,7 @@ export type FieldAuthScopes<Types extends SchemaTypes, Parent, Args extends {}>
       args: Args,
       context: Types['Context'],
       info: GraphQLResolveInfo,
-    ) => MaybePromise<AuthScopeMap<Types>>);
+    ) => MaybePromise<AuthScopeMap<Types> | boolean>);
 
 export type TypeGrantScopes<Types extends SchemaTypes, Parent> = (
   parent: Parent,