Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converter to the docs #57

Open
mmahalwy opened this issue May 18, 2021 · 4 comments
Open

Add converter to the docs #57

mmahalwy opened this issue May 18, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@mmahalwy
Copy link
Contributor

I should have noticed this instead of spending all day yesterday and today converting over 馃槄

I can add it to the docs if it's helpful!

@hayes
Copy link
Owner

hayes commented May 18, 2021

It's not very polished. It is mostly a proof of concept. I think it works, but the CLI is very bad. My plan had been to just have the converter embedded in the docs. Feel free to add it to the docs with a warning about it being very rough

@hayes
Copy link
Owner

hayes commented May 18, 2021

Also, I think when I wrote it, defining types I'm the schema builder generic was the only option (vs using classes or object refs, which are a much better default). Probably worth updating at some point soon

@hayes hayes added the documentation Improvements or additions to documentation label Jun 11, 2021
@harisvsulaiman
Copy link

@hayes what is the current status of the converter

@hayes
Copy link
Owner

hayes commented Apr 18, 2023

it works, but the generated code doesn't follow all best practices, and is a little less useful than I would like. You can definitely use it as a starting point if you want, and I'd be happy to help if you have questions, but I want to build something better before documenting it as a recommended tool. I have some experimental work in that direction, and a solid idea of where I'd like to take it, but the current form is not something that meets the quality bar for what I want to document in Pothos as a recommended tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants