Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting default requiredness for arguments breaks relay plugin functionality #64

Closed
NICHTJ3 opened this issue May 26, 2021 · 1 comment · Fixed by #65
Closed

Setting default requiredness for arguments breaks relay plugin functionality #64

NICHTJ3 opened this issue May 26, 2021 · 1 comment · Fixed by #65

Comments

@NICHTJ3
Copy link
Contributor

NICHTJ3 commented May 26, 2021 •
edited
Loading

The requiredness for the relay plugin args should be set to false. Currently if you set your default requiredness to true you cannot query for a connection without supplying the full set of arguments
@NICHTJ3 NICHTJ3 changed the title Setting default requirednes for arguments breaks relay plugin functionality Setting default requiredness for arguments breaks relay plugin functionality May 26, 2021
@NICHTJ3 NICHTJ3 mentioned this issue May 26, 2021
Merged
@hayes hayes closed this as completed in #65 May 26, 2021
@hayes
Copy link
Owner

hayes commented May 27, 2021

published:

@giraphql/plugin-dataloader@2.2.2
@giraphql/plugin-relay@2.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make relay connection args optional explicitly NICHTJ3/giraphql
2 participants
@hayes @NICHTJ3