Callstack size exceeded for getCreateInput on PrismaCrudGenerator

[LawJolla]

Hi Hayes and everyone. Thanks again for the amazing work.

I know this is outside Pothos's scope, but if anyone has thoughts I'd appreciate it.

I'm upgrading from Prisma 4.10 to 5.2 with

• "@pothos/core": "3.33.0",
• "@pothos/plugin-prisma": "3.57.0",
• "@pothos/plugin-prisma-utils": "0.11.0"

(I did try the following with Prisma 4.10 -- same issue)

I'm using the following generator. It's the same as published in the Pothos docs website except:

• I build all Prisma enums in the constructor
• Added Json as a mapScalarType

https://gist.github.com/LawJolla/3685374f3ef35cfb68219fbdf5abe570

When my app calls prismaGenerator.getUpdateInput(...) or prismaGenerator.getCreateInput(...) I get the following error

RangeError: Maximum call stack size exceeded
    at fields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:263:19)
    at Object.fields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+plugin-prisma-utils@0.11.0_@pothos+core@3.33.0_@pothos+plugin-prisma@3.57.0_@prisma+client@5.2.0_graphql@16.6.0/node_modules/@pothos/plugin-prisma-utils/src/schema-builder.ts:433:49)
    at ref (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/builder.ts:572:12)
    at <anonymous> (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:476:60)
    at ConfigStore.onTypeConfig (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:387:5)
    at <anonymous> (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:474:3)
    at config (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:467:5)
    at ConfigStore.addFields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:474:3)
    at SchemaBuilder.inputType (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/builder.ts:572:12)
    at ImplementableInputObjectRef.implement (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/refs/input-object.ts:47:16)
    at type (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+plugin-prisma-utils@0.11.0_@pothos+core@3.33.0_@pothos+plugin-prisma@3.57.0_@prisma+client@5.2.0_graphql@16.6.0/node_modules/@pothos/plugin-prisma-utils/src/schema-builder.ts:424:5)
    at <anonymous> (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:259:27)
    at PrismaCrudGenerator.getRef (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:558:56)
    at PrismaCrudGenerator.getCreateInput (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:257:17)
    at fields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:335:28)
    at Object.fields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+plugin-prisma-utils@0.11.0_@pothos+core@3.33.0_@pothos+plugin-prisma@3.57.0_@prisma+client@5.2.0_graphql@16.6.0/node_modules/@pothos/plugin-prisma-utils/src/schema-builder.ts:550:69)

Node.js v18.17.1

I've tried debugging this (a lot of debugger use!) and it doesn't look like it's recursive.

For help in debugging, I put a console log at 263 console.log(model.fields.length, fullName) and it appeared normal. Here's the log before the call stack error.

41 DealershipCreateWithoutDealsInput
18 AccountTransactionCreateWithoutDealershipInput
17 DealerAccountCreateWithoutTransactionsInput
41 DealershipCreateWithoutAccountsInput
9 BridgeAccountTransactionToTransactionItemCreateWithoutDealershipInput
16 VendorCreateWithoutBridgeToAccountTransactionsInput
41 DealershipCreateWithoutVendorsInput
33 DealCreateWithoutDealershipInput
27 StoreCreateWithoutDealsInput
41 DealershipCreateWithoutStoresInput
36 DealActionCreateWithoutDealershipInput
34 DealAddOnCreateWithoutActionsInput
33 DealCreateWithoutAddOnsInput
8 AutomatedMessageCreateWithoutDealInput
12 DateCreateWithoutDealInput
36 DealActionCreateWithoutDatesInput
33 DealCreateWithoutActionsInput
34 DealAddOnCreateWithoutDealInput
41 DealershipCreateWithoutAddOnsInput
17 DealerAccountCreateWithoutDealershipInput
14 PlaidAccountCreateWithoutDealerAccountInput
41 DealershipCreateWithoutPlaidAccountsInput
34 DealAddOnCreateWithoutDealershipInput
27 StoreCreateWithoutAddOnsInput
33 DealCreateWithoutStoreInput
36 DealActionCreateWithoutDealInput
41 DealershipCreateWithoutActionsInput
10 DealerLicensePlateCreateWithoutDealershipInput
27 StoreCreateWithoutLicensePlatesInput
36 DealActionCreateWithoutStoreInput
54 VehicleCreateWithoutActionsInput
41 DealershipCreateWithoutVehiclesInput
19 DealerLicensePlateLogCreateWithoutDealershipInput
10 DealerLicensePlateCreateWithoutLicensePlateLogsInput
41 DealershipCreateWithoutLicensePlatesInput
14 DealerLicensePlateUserCreateWithoutDealershipInput
17 AddressCreateWithoutDealerLicensePlateUserInput
36 UserCreateWithoutAddressesInput
21 DriverLicenseCreateWithoutUserInput
17 AddressCreateWithoutDriverLicenseInput
16 VendorCreateWithoutAddressesInput
9 BridgeAccountTransactionToTransactionItemCreateWithoutVendorInput
41 DealershipCreateWithoutBridgeAccountTransactionToTransactionItemInput
10 DealershipFloorPlanCreateWithoutDealershipInput
6 FloorPlanProviderCreateWithoutDealershipFloorPlansInput
22 FloorPlanCreateWithoutFloorPlanProviderInput
10 FloorPlanActionCreateWithoutFloorplanInput
9 FloorPlanLineItemCreateWithoutFloorPlanInput
54 VehicleCreateWithoutFloorPlansInput
27 StoreCreateWithoutVehiclesInput
34 DealAddOnCreateWithoutStoreInput
54 VehicleCreateWithoutAddOnsInput
10 VehicleBoughtFromCreateWithoutVehicleInput
17 AddressCreateWithoutVehicleBoughtFromInput
14 DealerLicensePlateUserCreateWithoutAddressInput
41 DealershipCreateWithoutLicensePlateUsersInput
12 DealershipIntegrationCreateWithoutDealershipInput
11 DealershipIntegrationServiceCreateWithoutDealershipsInput
34 DealLineItemCreateWithoutDealershipInput
36 DealActionCreateWithoutLineItemsInput
27 StoreCreateWithoutActionsInput
10 DealerLicensePlateCreateWithoutStoreInput
19 DealerLicensePlateLogCreateWithoutDealerLicensePlateInput
41 DealershipCreateWithoutLicensePlateLogsInput
28 DocCreateWithoutDealershipInput
33 DealCreateWithoutDocsInput
34 DealLineItemCreateWithoutDealInput
34 DealLineItemCreateWithoutInheritsFromInput
33 DealCreateWithoutLineItemsInput
28 DocCreateWithoutDealInput
41 DealershipCreateWithoutDocsInput
18 EmailSubscriberCreateWithoutDealerInput
36 UserCreateWithoutEmailSubscribersInput
41 DealershipCreateWithoutWorkersInput
6 FacebookAdGroupCreateWithoutDealershipInput
26 FileCreateWithoutDealershipInput
33 DealCreateWithoutFilesInput
13 NoteCreateWithoutDealInput
41 DealershipCreateWithoutNotesInput
8 PermissionCreateWithoutDealershipInput
36 UserCreateWithoutPermissionsInput
41 DealershipCreateWithoutCustomersInput
13 NoteCreateWithoutDealershipInput
33 DealCreateWithoutNotesInput
26 FileCreateWithoutDealInput
41 DealershipCreateWithoutFilesInput
14 PlaidAccountCreateWithoutDealershipInput
17 DealerAccountCreateWithoutPlaidInput
15 AccountCheckCreateWithoutAccountInput
18 AccountTransactionCreateWithoutCheckInput
41 DealershipCreateWithoutTransactionsInput
11 SiteBannerCreateWithoutDealershipInput
27 StoreCreateWithoutDealershipInput
19 DealerLicensePlateLogCreateWithoutStoreInput
14 DealerLicensePlateUserCreateWithoutCheckoutsInput
21 DriverLicenseCreateWithoutDealerLicensePlateUserInput
26 FileCreateWithoutDriverLicenseInput
15 SignerCreateWithoutSignatureFilesInput
5 ElectronicSignatureConsentCreateWithoutSignerInput
36 UserCreateWithoutSignersInput
17 AddressCreateWithoutUserInput
21 DriverLicenseCreateWithoutAddressInput
14 DealerLicensePlateUserCreateWithoutDriverLicenseInput
36 UserCreateWithoutDealerLicensePlateUserInput
14 CustomerPlaidAccountCreateWithoutUserInput
10 CustomerVehicleSearchCreateWithoutUserInput
19 DealerLicensePlateLogCreateWithoutUserInput
27 StoreCreateWithoutLicensePlateLogInput
34 DealLineItemCreateWithoutStoreInput
41 DealershipCreateWithoutLineItemsInput
33 TaskCreateWithoutDealershipInput
34 DealAddOnCreateWithoutTasksInput
36 DealActionCreateWithoutAddOnInput
12 DateCreateWithoutActionInput
33 DealCreateWithoutDatesInput
7 OfferCreateWithoutDealInput
33 TaskCreateWithoutDealInput
41 DealershipCreateWithoutTasksInput
16 TransactionItemCreateWithoutDealershipInput
18 AccountTransactionCreateWithoutItemsInput
15 AccountCheckCreateWithoutAccountTransactionInput
17 DealerAccountCreateWithoutChecksInput
18 AccountTransactionCreateWithoutAccountInput
34 DealLineItemCreateWithoutTransactionInput
27 StoreCreateWithoutDealLineItemInput
28 DocCreateWithoutStoreInput
54 VehicleCreateWithoutDocsInput
8 AdvertisingCreateWithoutVehicleInput
8 FacebookAdCreateWithoutAdvertisingInput
36 DealActionCreateWithoutVehicleInput
36 DealActionCreateWithoutInheritsFromInput
34 DealLineItemCreateWithoutActionInput
33 TaskCreateWithoutLineItemsInput
33 DealCreateWithoutTasksInput
17 AddressCreateWithoutDealsInput
10 VehicleBoughtFromCreateWithoutAddressInput
16 VendorCreateWithoutVehicleBoughtFromInput
17 AddressCreateWithoutVendorInput
33 DealCreateWithoutAddressesInput
15 SignerCreateWithoutDealsInput
26 FileCreateWithoutSignerInput
27 StoreCreateWithoutFilesInput
33 TaskCreateWithoutStoreInput
54 VehicleCreateWithoutTasksInput
34 DealAddOnCreateWithoutVehicleInput
34 DealAddOnCreateWithoutInheritsFromInput
33 TaskCreateWithoutAddOnsInput
27 StoreCreateWithoutTasksInput
26 FileCreateWithoutStoreInput
36 UserCreateWithoutFilesInput
14 DealerLicensePlateUserCreateWithoutUserInput
19 DealerLicensePlateLogCreateWithoutDealerLicensePlateUserInput
36 UserCreateWithoutLicensePlateLogInput
10 EmailAddressCreateWithoutUserInput
33 DealCreateWithoutEmailAddressesInput
16 PhoneNumberCreateWithoutDealsInput
36 UserCreateWithoutPhoneNumbersInput
18 EmailSubscriberCreateWithoutUserInput
41 DealershipCreateWithoutEmailSubscribersInput
7 TransactionTypeAllowedListCreateWithoutDealershipInput
36 UserCreateWithoutDealershipInput
26 FileCreateWithoutUserInput
54 VehicleCreateWithoutFilesInput
19 DealerLicensePlateLogCreateWithoutVehicleInput
34 DealLineItemCreateWithoutVehicleFeeInput
18 AccountTransactionCreateWithoutDealLineItemsInput
16 TransactionItemCreateWithoutAccountTransactionInput
15 AccountCheckCreateWithoutItemsInput
41 DealershipCreateWithoutTransactionItemInput
36 UserCreateWithoutWorksForInput
8 InAppNotificationCreateWithoutUserInput
9 NotificationCreateWithoutInAppNotificationsInput
13 NoteCreateWithoutFromInput
54 VehicleCreateWithoutNotesInput
28 DocCreateWithoutVehicleInput
27 StoreCreateWithoutDocsInput
54 VehicleCreateWithoutStoreInput
26 FileCreateWithoutVehicleInput
21 DriverLicenseCreateWithoutFileInput
36 UserCreateWithoutDriverLicensesInput
8 PermissionCreateWithoutUserInput
41 DealershipCreateWithoutUserInput
54 VehicleCreateWithoutDealershipInput
13 NoteCreateWithoutVehicleInput
36 UserCreateWithoutNotesInput
16 PhoneNumberCreateWithoutUserInput
16 VendorCreateWithoutPhoneNumbersInput
16 TransactionItemCreateWithoutVendorInput
15 VehicleReconCreateWithoutBankLinkInput
54 VehicleCreateWithoutReconInput
33 TaskCreateWithoutVehicleInput
34 DealLineItemCreateWithoutTaskInput
54 VehicleCreateWithoutDealFeesInput
7 VehicleDateCreateWithoutVehicleInput
11 VehicleImageCreateWithoutVehicleInput
6 VehicleImageTagCreateWithoutImageInput
9 VehicleOptionCreateWithoutVehicleInput
6 VehicleOptionTagCreateWithoutVehicleOptionInput
11 VehiclePriceCreateWithoutVehicleInput
36 UserCreateWithoutVehiclePriceInput
11 PhysicalAccessCreateWithoutUserInput
6 PhysicalAccessLogCreateWithoutAccessInput
16 PhoneNumberCreateWithoutPhysicalAccessInput
33 DealCreateWithoutPhoneNumbersInput
10 EmailAddressCreateWithoutDealsInput
36 UserCreateWithoutEmailAddressesInput
15 SignerCreateWithoutUserInput
9 SignedDocCreateWithoutSignerInput
28 DocCreateWithoutSignedInput
28 DocCreateWithoutInheritsFromOppositeInput
9 SignedDocCreateWithoutDocInput
15 SignerCreateWithoutUsedToSignInput
6 SignerTagCreateWithoutSignerInput
33 DealCreateWithoutSignersInput
9 TradeCreateWithoutDealsInput
36 UserCreateWithoutDealsInput
7 UserNotificationPreferenceCreateWithoutUserInput
11 VehiclePriceCreateWithoutUserInput
54 VehicleCreateWithoutPricesInput
15 VehicleReconCreateWithoutVehicleInput
16 TransactionItemCreateWithoutVehicleReconInput
16 VendorCreateWithoutTransactionsInput
16 PhoneNumberCreateWithoutVendorInput
11 PhysicalAccessCreateWithoutPhoneNumbersInput
36 UserCreateWithoutPhysicalAccessInput
33 DealCreateWithoutUsersInput
54 VehicleCreateWithoutDealsInput
12 VehicleVideoCreateWithoutVehicleInput
12 DisclosureCreateWithoutVehiclesInput
33 DealCreateWithoutDisclosuresInput
24 DealFinanceAppCreateWithoutDealInput
7 DealFinanceBuyerCreateWithoutBuyerApplicationsInput
7 StripeIdentityCreateWithoutDealFinanceBuyerInput
24 DealFinanceAppCreateWithoutCoBuyerInput
20 DealFinanceOfferCreateWithoutApprovedOfferInput
24 DealFinanceAppCreateWithoutOffersInput
7 DealFinanceBuyerCreateWithoutCoBuyerApplicationsInput
24 DealFinanceAppCreateWithoutBuyerInput
20 DealFinanceOfferCreateWithoutApplicationInput
24 DealFinanceAppCreateWithoutApprovedOfferInput
36 UserCreateWithoutFinanceAppsInput
7 DeviceCreateWithoutUsersInput
28 DocCreateWithoutUsersInput
34 DealAddOnCreateWithoutDocsInput
34 DealLineItemCreateWithoutDealAddOnsInput
26 FileCreateWithoutCompletedFileInput
15 SignerCreateWithoutDocsInput
33 TaskCreateWithoutAlertIndividualUsersInput
33 DealCreateWithoutFinanceAppsInput
12 DisclosureCreateWithoutDealsInput
54 VehicleCreateWithoutDisclosuresInput
33 DealCreateWithoutVehiclesInput
22 FloorPlanCreateWithoutVehicleInput
6 FloorPlanProviderCreateWithoutFloorPlansInput

And replacing console.log with console.trace gave this call stack before the crash.

Trace: Current call stack:
    at fields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:263:19)
    at Object.fields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+plugin-prisma-utils@0.11.0_@pothos+core@3.33.0_@pothos+plugin-prisma@3.57.0_@prisma+client@5.2.0_graphql@16.6.0/node_modules/@pothos/plugin-prisma-utils/src/schema-builder.ts:433:49)
    at ref (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/builder.ts:572:12)
    at <anonymous> (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:476:60)
    at ConfigStore.onTypeConfig (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:387:5)
    at <anonymous> (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:474:3)
    at config (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:467:5)
    at ConfigStore.addFields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/config-store.ts:474:3)
    at SchemaBuilder.inputType (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/builder.ts:572:12)
    at ImplementableInputObjectRef.implement (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+core@3.33.0_graphql@16.6.0/node_modules/@pothos/core/src/refs/input-object.ts:47:16)
    at type (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+plugin-prisma-utils@0.11.0_@pothos+core@3.33.0_@pothos+plugin-prisma@3.57.0_@prisma+client@5.2.0_graphql@16.6.0/node_modules/@pothos/plugin-prisma-utils/src/schema-builder.ts:424:5)
    at <anonymous> (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:259:27)
    at PrismaCrudGenerator.getRef (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:559:56)
    at PrismaCrudGenerator.getCreateInput (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:257:17)
    at fields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/packages/shared-pothos/src/PrismaCrudGenerator.ts:336:28)
    at Object.fields (/Users/denniswalsh/WebstormProjects/wk-mono-repo/node_modules/.pnpm/@pothos+plugin-prisma-utils@0.11.0_@pothos+core@3.33.0_@pothos+plugin-prisma@3.57.0_@prisma+client@5.2.0_graphql@16.6.0/node_modules/@pothos/plugin-prisma-utils/src/schema-builder.ts:550:69)

Any thoughts are greatly appreciated!!

[hayes]

The example generators are intentionally simplistic and are implemented in a way that should make it obvious they shouldn't be used as is. The implementation here is using a basic depth first crawl of types which naturally will result in exceeding stack depth limits on a sufficiently complex schema.

The only real solution here is to write a generator that is a little smarter about how it generates types. You can also increase the stack depth limit in node, but thats just hacking around the underlying issue.

The generator examples are meant as simplistic examples to get you started building a real generator, not as an actual solution to use in your production applications, and these types of issues won't be addressed in the examples. I've tried to be as clear as possible about this by not publishing it as a package, and adding warnings to the docs

[LawJolla]

@hayes you were clear. "I know this is outside Pothos's scope..."

We worked on the generator previously.

I hope your day improves.

[hayes]

Sorry, these generators have been a source of a lot a frustration and caused a disproportionately high support load.

To give you a slightly better answer, the way to handle this is to use some sort of unrolling/trampoline pattern in the generator.

More specifically, what I'd likely do is split up the getX methods into 2 pieces, one to create/return the ref, and one that handles the implementation (or maybe just the loading of the fields), the pushing the implementations (or just field definitions) into an array to be processed directly in a loop rather than having each definition recursively call into the next definition via some getX call. This is a little vague, but would likely give you a general direction.

You can also try node --stack_size=1200 to try to figure out how close you are to the limit, it might be possible that some smaller optimization can bring you back under the limit.

[LawJolla]

I greatly appreciate it @hayes . I'm sorry to contribute to your frustration.

I will work on it and try to contribute back.