Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this be used in place of hayes0724 / shopify-webpack-themekit? #44

Closed
adrianocr opened this issue Jan 23, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@adrianocr
Copy link

There seems to be a lot of overlap between the two and I'm not fully understanding where one should take the place of the other?

@adrianocr adrianocr added the bug Something isn't working label Jan 23, 2021
@adrianocr
Copy link
Author

Seems like hayes0724/shopify-webpack-themekit is more or less just a pre-defined theme type of setup whereas hayes0724/shopify-packer is trying to be a Slate replacement.

@hayes0724 hayes0724 reopened this Jan 25, 2021
@hayes0724
Copy link
Owner

shopify-webpack-themekit is a webpack setup I used for many years (pre Slate) where everything (build tools, theme, etc) are all in one repo. When Slate was released there were several features I liked and wanted to add to shopify-webpack-themekit. Installing as a global node module that can be configured in a separate repo was a key feature that required a complete rebuild of the project. I created shopify-packer for this purpose and maintain both. shopify-webpack-themekit receives backports from hayes0724/shopify-packer since they are mostly compatible.

hayes0724/shopify-packer

  • Drop in replacement for Slate (good for team projects where other members have Slate experience)
  • Build tools are separate from theme (@hayes0724/packer-blank-theme)
  • Easier to update existing projects
  • Easy to use with existing themes
  • Base theme is separate and not required
  • CLI tools for common tasks (theme create, list, init, download, zip)

hayes0724/shopify-webpack-themekit

  • Single repo for build and project
  • Receives backports from packer
  • Easier to edit build directly
  • Harder to update previous build portion projects (since build and project are in the same repo)
  • Hard to work with existing sites
  • No CLI Tools

Repository owner locked and limited conversation to collaborators Mar 1, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants