Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken cross-compilation #97

Closed
hazcod opened this issue Dec 10, 2020 · 5 comments
Closed

Broken cross-compilation #97

hazcod opened this issue Dec 10, 2020 · 5 comments

Comments

@hazcod
Copy link
Owner

hazcod commented Dec 10, 2020

The release workflow seems to miss some dependencies to be able to cross-compile to e.g. freebsd.

@Kwbmm
Copy link
Contributor

Kwbmm commented Mar 21, 2021

Hello!

As stated here, I managed to craft some binaries that are not affected anymore by the sqlite3 driver missing. I'd be happy to make a PR but I won't be able to produce binaries for all the platforms currently released.

As of now, the only ones that are 100% working are linux x64, linux arm and (probably) darwin x64.

Would doing an initial PR to build for these 3 platform work for you?

In the future, we will build up on this and eventually reach working binaries for other platforms (linux 32, win 32/64, freebsd, etc...).

@hazcod
Copy link
Owner Author

hazcod commented Mar 21, 2021

@Kwbmm thank you so much for your work on this! I'd love a PR!

@hazcod
Copy link
Owner Author

hazcod commented Mar 22, 2021

@Kwbmm I noticed the release pipeline now returns the following: release failed after 0.08s error=git tag v1.1.2 was not made against commit b2bbba1f491eaae2c1b13edc9298252fbaf4e7c1

https://github.com/hazcod/enpass-cli/runs/2163531155?check_suite_focus=true

@Kwbmm
Copy link
Contributor

Kwbmm commented Mar 22, 2021

Yup, I forgot to create the new tag in the release workflow. Will fix that

@hazcod
Copy link
Owner Author

hazcod commented Mar 22, 2021

@hazcod hazcod closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants