Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve map re-config capabilities #14750

Open
davidkarlsen opened this issue Mar 24, 2019 · 3 comments
Open

Improve map re-config capabilities #14750

davidkarlsen opened this issue Mar 24, 2019 · 3 comments
Labels
Milestone

Comments

@davidkarlsen
Copy link

davidkarlsen commented Mar 24, 2019

I define/configure the maps dynamically from a client (using client/server model), but there are two places it could be improved:

  • Allow for changing the same parameters programatically which are allowed from the mancenter ui, e.g. TTL, eviction policy etc
  • If destroy()'ing and creating the map - it still fails due to configuration mismatch
hazelcastInstance.getMap(CorsAccountServiceImpl.CORS_ACCOUNT_LIST_CACHE).destroy();
// will still fail:
          var corsAccountListCacheConfig = new MapConfig()
              .setTimeToLiveSeconds(60*30)
              //.setMaxSizeConfig(new MaxSizeConfig().setSize(10000))
              .setName(CorsAccountServiceImpl.CORS_ACCOUNT_LIST_CACHE)
              .setEvictionPolicy(EvictionPolicy.LRU);
          hazelcastInstance.getConfig().addMapConfig(corsAccountListCacheConfig );
@burakcelebi
Copy link
Member

Hi @davidkarlsen! Thanks for your enhancement request! I'm now monitoring this type of requests closely. I have just reviewed your request with @ahmetmircik. He is going to ask you a few questions to clarify your use case. Stay tuned! :)

@ahmetmircik
Copy link
Member

Hi @davidkarlsen,

I agree that re-configuration is a good addition. You can do it for imap from mancenter ui but only for a subset of imap configuration as you already knew.

We will keep this issue open as an enhancement request. Let's see what we can do with it.

Regarding this:

If destroy()'ing and creating the map - it still fails due to configuration mismatch

Destroying map and destroying map-config are two separate things. There can be other maps that uses same config. All dynamic configs are using config-name to identify themselves atm. So you need a new map-config with a new name.

@davidkarlsen
Copy link
Author

Yeah - I know we can click around in the mancenter - but we want a CI/CD driven workflow with few or no buttons to click - so we get a separation of concerns between hz ops and app ops

@mmedenjak mmedenjak added the Source: Community PR or issue was opened by a community user label Nov 6, 2019
@mmedenjak mmedenjak added this to the Backlog milestone Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants